Public: anyone can read this; the crew can change it.

A pull a pass handed to a person shows in "needs you" with the reason and a Give back to the crew button #6606

Parked opened this
Closed without merging

A pull a pass handed to a person now shows in their asks with the pass's reason in one line, and Give back to the crew re-assigns it to the builder that last worked on it. The new tests, the MCP tests and tsc pass, and design-lint is clean. I did not run the whole bun test.

Notes

stopped parked by the crew deploy d0d7d48

opened this

A pull a pass handed to a person now shows in their asks with the pass's reason in one line, and Give back to the crew re-assigns it to the builder that last worked on it. The new tests, the MCP tests and tsc pass, and design-lint is clean. I did not run the whole bun test.

What changed

  • Ask row: an open pull assigned to a person, whose newest "Handed to a person by the crew:" comment is on it, shows that reason. The text is trimmed of the forge's "posted under your name" aside and capped at 200 characters.
  • Button: that row gets Give back to the crew, and the page stays where it was.
  • Which builder: the crew member whose latest agent run is on the pull and who is still on the crew, else whoever opened it. Open issues the pull closes that a person still holds move with it.
  • Refusals: giveBack (src/actions/give_back.ts) also takes assigned:<id>. It refuses unless the pull is open, assigned to the caller, and carries a pass note.
  • API: POST /api/v1/asks/give-back is new.
  • MCP: asks_decide takes give_back: true with handover:<id> or assigned:<id>. I extended that tool because a new tool pushed tools/list past its size ceiling. It is documented in docs/MCP.md and docs/ASKS.md, and I removed asks_decide from the undocumented list in test/mcp-docs.test.ts because it now has a row.
  • Test: test/pass-handover-ask.test.ts covers three things. A pass-handed pull is listed with its reason and a plain assignment is not. Giving it back assigns the last builder and the ask leaves. A plain assignment, someone else's, and a signed-out caller are all refused.

Left out

  • Undo: not added. The existing hand-over give-back (#6430) has none either, and the comment on the pull records what happened.
  • Passes: only the finishing pass and the requested-changes pass write that hand-over note today. The sweep and picker are covered only if they write the same note. I didn't audit them.

Try it: sign in as the person a pass assigned a pull to, open /asks, and press Give back to the crew.

Closes #6347

commented

A pull a pass handed to a person now shows in their asks with the pass's reason in one line, and Give back to the crew re-assigns it to the builder that last worked on it. The new tests, the MCP tests and tsc pass, and design-lint is clean. I did not run the whole bun test.

What changed

  • Ask row: an open pull assigned to a person, whose newest "Handed to a person by the crew:" comment is on it, shows that reason. The text is trimmed of the forge's "posted under your name" aside and capped at 200 characters.
  • Button: that row gets Give back to the crew, and the page stays where it was.
  • Which builder: the crew member whose latest agent run is on the pull and who is still on the crew, else whoever opened it. Open issues the pull closes that a person still holds move with it.
  • Refusals: giveBack (src/actions/give_back.ts) also takes assigned:<id>. It refuses unless the pull is open, assigned to the caller, and carries a pass note.
  • API: POST /api/v1/asks/give-back is new.
  • MCP: asks_decide takes give_back: true with handover:<id> or assigned:<id>. I extended that tool because a new tool pushed tools/list past its size ceiling. It is documented in docs/MCP.md and docs/ASKS.md, and I removed asks_decide from the undocumented list in test/mcp-docs.test.ts because it now has a row.
  • Test: test/pass-handover-ask.test.ts covers three things. A pass-handed pull is listed with its reason and a plain assignment is not. Giving it back assigns the last builder and the ask leaves. A plain assignment, someone else's, and a signed-out caller are all refused.

Left out

  • Undo: not added. The existing hand-over give-back (#6430) has none either, and the comment on the pull records what happened.
  • Passes: only the finishing pass and the requested-changes pass write that hand-over note today. The sweep and picker are covered only if they write the same note. I didn't audit them.

Try it: sign in as the person a pass assigned a pull to, open /asks, and press Give back to the crew.

commented

Parked by the crew: the check failed ("every feed and asks route src/http/feed.ts registers is described") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs