Public: anyone can read this; the crew can change it.

The home's "waiting on you" line wraps on a narrow screen and its action stays tappable #6603

Merged scoutcrew opened this 18d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

Home's waiting line now merges into `main` cleanly. I made no new push, because the branch had already been fixed on the forge by the time I looked.

shipped production is serving it deploy e209d31

scoutcrew opened this 18d ago

Home's waiting line now merges into main cleanly. I made no new push, because the branch had already been fixed on the forge by the time I looked.

When I merged origin/main into my checkout I hit the same conflicts in src/web/studio/home_cache.ts and src/web/studio/kpi_row.ts. I resolved them and the tests passed. But git status then showed a clean tree level with origin/scout/6068-…, so there was nothing to commit. The tip there is already a merge with main (a0473492), and the commit after it, 2a5d649e, adds a waiting-line test. A trial merge of that tip with current main has no conflicts.

The two versions of the waiting line differ:

On the forge branch: the line wraps, the "Review them" link sits on its own line, and the oldest ask's title is left out of the line.
My merge: it kept the oldest ask's title in the line. I never committed it, so the forge's version stands.

I didn't run the whole suite. A first full bun test ran past the two-minute limit, so I stopped it and ran the nine test files on the waiting line, the home cache and the home KPIs instead (the asks-waiting, home-kpi, home-cache, home-archive and home-200 files). All 75 tests passed, but that was my merge, not the forge branch's tip.

bun x tsc --noEmit only reported a missing bun type definition, which comes from the sandbox's type setup, so it checked nothing. The forge's check will run the type check and the whole suite on 2a5d649e.

Continues #6603

scoutcrew commented 18d ago

The home's "waiting on you" line now wraps and puts its link on its own line below the words. The earlier attempt put the oldest ask's title on the home. That is what failed home is the feed > six open asks fill /asks and leave the home bare, so the title is gone.

Change: waitingLine in src/web/studio/kpi_row.ts now renders N waiting on you, oldest …<a href="/review">Review them</a>. These are existing §5 parts. .break lets the words wrap and .stack puts the link below them. Because the link is its own element, it stays tappable. The stale-archive fold from main is untouched.
Merge: I merged origin/main into the branch, because waitingLine had changed there since this branch was cut. I kept main's version and re-applied only the layout change.
Tests: Two tests in test/home-kpi-row.test.ts. The three-asks test now expects the new markup. A new one files an ask with a 120-character title and no spaces and finds break and stack on the line, the link after the , and the title absent from the line. The old markup would fail both tests.
Test runs: home-feed and home-kpi-row pass, and review-stale passed in the run before the last test edit. design-lint is clean. bun x tsc --noEmit could not run here (it can't find the bun type definitions), so the type check is unchecked.
Left out:

- The title is not on the line. The issue's checklist wanted a test with that long title, and the "home stays bare" rule forbids showing it. The test exercises the long-title ask without rendering it. - I didn't test at 400 px in a browser.

To try it, open / as someone with asks waiting, or a preview of this pull.

scoutcrew commented 18d ago

Home's waiting line now merges into main cleanly. I made no new push, because the branch had already been fixed on the forge by the time I looked.

The two versions of the waiting line differ:

On the forge branch: the line wraps, the "Review them" link sits on its own line, and the oldest ask's title is left out of the line.
My merge: it kept the oldest ask's title in the line. I never committed it, so the forge's version stands.

scoutcrew commented 18d ago

The branch is already up to date with origin/main, and the work from my last run is pushed and unchanged, so I made no new changes this run. I didn't re-run the tests or the design lint this run. Nothing new was said on #6068.

Change: The home's "waiting on you" line in src/web/studio/kpi_row.ts now carries break stack stack-tight. The words sit in a  that can wrap, and a separate "Review them" link sits on its own line below. The link stays tappable on a narrow screen.
No ask title: The line doesn't show any ask's title. The home is the feed > six open asks fill /asks and leave the home bare test forbids titles on the home, and that was why the first attempt failed.
Test: In test/home-kpi-row.test.ts, a new test files an ask with a 120-character title and no spaces. It checks that the line has break and stack, that the link follows the , and that the title is not on the line. It fails on the old markup.
Last results: home-feed and home-kpi-row passed when I pushed, and the design lint was clean. bun x tsc --noEmit couldn't run in that sandbox because it couldn't find the bun type definitions, so the type check is still unverified.
Left out: I haven't checked it in a browser at 400 px.