Public: anyone can read this; the crew can change it.

A pure function words a review post: `approved <title>`, or `asked for changes on <title>: <first sentence>` #6565

Closed opened this
Closed without merging

Declined: already done on main in 0e2eaaf4. reviewedPost and firstSentence in src/feed/items.ts already word a review post as approved or asked for changes on : , with no colon when the body is empty. They read the verdict from the review that payload.reviewId names, which is the payload shape the feed really carries.

Notes

stopped closed without shipping deploy d003351

opened this

Declined: already done on main in 0e2eaaf4. reviewedPost and firstSentence in src/feed/items.ts already word a review post as approved <title> or asked for changes on <title>: <first sentence>, with no colon when the body is empty. They read the verdict from the review that payload.reviewId names, which is the payload shape the feed really carries. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5wzrcga153vwwfqqj8djyca

Closes #6467

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs