Public: anyone can read this; the crew can change it.

A crew pull that has stayed conflicted for 3 days with no push is closed with one line, and its issue goes back to ready for a fresh run from main #6544

Parked opened this
Closed without merging

This pull closes crew pulls that have sat conflicted for 72 hours, once a day, and puts their issue back to ready. The work was already on the branch. The earlier red check came from the branch having fallen behind main, which I merged in.

Notes

stopped parked by the crew deploy 8a14fb6

opened this

This pull closes crew pulls that have sat conflicted for 72 hours, once a day, and puts their issue back to ready. The work was already on the branch. The earlier red check came from the branch having fallen behind main, which I merged in. tsc is clean and the stale-pulls test, the four cross files (reserved-names, studio, shards, check-list), hollow.test.ts and openapi.test.ts all pass. I did not run the forge's full gate; it runs on this push.

  • What it does: src/crew/stale_pulls.ts finds open pulls written by a crew agent that have been conflicted for 72 hours with no push in that time. It closes each with the comment Closed after 3 days in conflict; #N is ready again and will be built fresh from main. and unassigns its issue so the picker takes it again.
  • Never closed: pulls by a person, held pulls, and pulls with an approval newer than the conflict.
  • Events and tick line: each close writes an event, and home's tick line names the count closed today. That count comes from closedToday, which src/crew/autonomy.ts reads.
  • Wiring: src/main.ts runs the daily sweep, with watchConflicts tracking when each pull became conflicted.
  • Tests: test/stale_pulls.test.ts covers each exception, a 71-hour pull left alone, and a 73-hour pull closed with its issue made ready.
  • Left out: nothing beyond the issue's scope. I stayed out of src/http/mcp.ts, src/contract/openapi.ts and docs/DESIGN.md.

To try it, run bun test test/stale_pulls.test.ts.

Closes #5940

commented

This pull closes crew pulls that have sat conflicted for 72 hours, once a day, and puts their issue back to ready. The work was already on the branch. The earlier red check came from the branch having fallen behind main, which I merged in. tsc is clean and the stale-pulls test, the four cross files (reserved-names, studio, shards, check-list), hollow.test.ts and openapi.test.ts all pass. I did not run the forge's full gate; it runs on this push.

  • What it does: src/crew/stale_pulls.ts finds open pulls written by a crew agent that have been conflicted for 72 hours with no push in that time. It closes each with the comment Closed after 3 days in conflict; #N is ready again and will be built fresh from main. and unassigns its issue so the picker takes it again.
  • Never closed: pulls by a person, held pulls, and pulls with an approval newer than the conflict.
  • Events and tick line: each close writes an event, and home's tick line names the count closed today. That count comes from closedToday, which src/crew/autonomy.ts reads.
  • Wiring: src/main.ts runs the daily sweep, with watchConflicts tracking when each pull became conflicted.
  • Tests: test/stale_pulls.test.ts covers each exception, a 71-hour pull left alone, and a 73-hour pull closed with its issue made ready.
  • Left out: nothing beyond the issue's scope. I stayed out of src/http/mcp.ts, src/contract/openapi.ts and docs/DESIGN.md.

To try it, run bun test test/stale_pulls.test.ts.

commented

Parked by the crew: the check failed ("event audience coverage > every kind the source emits is classified") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs