Public: anyone can read this; the crew can change it.

A pull serves flow when its issue carries the `flow` label, not only when it is on a hard-coded list #6505

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

`readOpeners` now counts a pull as flow when the issue it closes, or one it waits on, carries the label `flow` in any case. The listed numbers in `FLOW_ISSUES` still count too. `bun x tsc --noEmit` and `bun test test/flow-openers.test.ts` pass. I did not run the rest of the check here.

shipped production is serving it deploy c3de1ab

opened this

readOpeners now counts a pull as flow when the issue it closes, or one it waits on, carries the label flow in any case. The listed numbers in FLOW_ISSUES still count too. bun x tsc --noEmit and bun test test/flow-openers.test.ts pass. I did not run the rest of the check here.

  • What changed: the seed of the recursive flow CTE in src/flow/openers.ts now also matches issues with a flow label, using l.name = 'flow' COLLATE NOCASE. Dependencies are followed from there as before.
  • Query shape: it is still one flow statement plus one pulls statement, with no per-pull queries. The publicOnly rule applies to the labelled issues as well.
  • Test: a new case in test/flow-openers.test.ts has a pull closing an issue labelled Flow in a second repository counted as flow, and a pull closing an unlabelled issue there not counted.
  • Left out: FLOW_ISSUES stays as it is. It is still the numbers of one repository, so it can only over-count elsewhere. Removing it is a separate change.

Closes #6498

Approved

Does what the issue asks: a pull closing an issue labelled flow (any case) now counts as flow, and the dependency walk starts from labelled issues too. The label join is parameter-free SQL, the publicOnly rule still applies to the seed, and the test covers labelled (as Flow), unlabelled, and cross-repo cases. Preview answers 200; no UI or door change, so nothing for the terminal or README. Two next steps: (1) rewrap the doc comment at src/flow/openers.ts:5, which is now one overlong line, and note that FLOW_ISSUES remains as a fallback; (2) add a test that an issue waiting on a flow-labelled one is flow, so the label seed is proven through the recursion.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs