A reviewed-pull post says the verdict, approved or changes asked, and the reviewer's first sentence #6459

Pull #6459 now merges into main. The merge conflict in src/feed/items.ts is resolved, and the merge is already on the branch (2511c944), so there was nothing left to push.

I couldn't tell where that merge commit came from. The tree was clean when I went to commit. The branch contains origin/main and has no conflict markers left.

Two edits fixed the conflict:

• Imports: the file now has both getReview from the pull-review change and commentAnchor from main.
• Switch cases: pull.reviewed still goes through reviewedPost, and look.taken and app.serving take main's newer versions.

bun x tsc --noEmit is clean.

I ran bun test with file arguments, and it ran the whole suite rather than only the feed and review files. One look test failed: "a dark capture is truly dark". I didn't investigate it. The log also showed two network-outbound denials for *.forge.test:443. The suite's SSH and cgroup tests were skipped here as expected.

Because the merge commit was already there, the push in this turn didn't happen. The forge should rerun the check on the commit as it stands.

Continues #6459

A reviewed-pull post now says the verdict, and asked-for-changes posts rank above approvals. The new feed tests and the feed suites pass and the type check is clean. I did not run bun scripts/design-lint.ts, and src/web/ is untouched.

The branch already held the work, but its merge of main was left half-finished with a conflict in src/feed/items.ts. I resolved the conflict (keeping main's look and release posts) and committed the merge.

• Wording: pull.reviewed posts read approved <title> or asked for changes on <title>: <first sentence, ≤100 chars>. If the review has no body, the colon and sentence are dropped. The verdict and sentence come from the review the event names, via its reviewId.
• Event payload: src/actions/pulls.ts now puts reviewId on the review events that lacked it. Older events without one keep the old words.
• Fallback: a review that is gone or has no verdict keeps reviewed a pull request: <title>.
• Ranking: a changes-asked post gets urgency 1; an approval has none.
• Tests: test/feed-reviewed.test.ts seeds one review of each verdict and checks the words and the order on / and in the MCP feed. It also checks that a missing or verdict-less review falls back to the old words.

Not done: line comments (addReviewComment) still post as reviewed a pull request, since they carry no verdict.

To try it, open a review as changes_requested on a pull and look at the feed. Its post should read asked for changes on … above any approved … post.

Pull #6459 now merges into main. The merge conflict in src/feed/items.ts is resolved, and the merge is already on the branch (2511c944), so there was nothing left to push.

I couldn't tell where that merge commit came from. The tree was clean when I went to commit. The branch contains origin/main and has no conflict markers left.

Two edits fixed the conflict:

• Imports: the file now has both getReview from the pull-review change and commentAnchor from main.
• Switch cases: pull.reviewed still goes through reviewedPost, and look.taken and app.serving take main's newer versions.

bun x tsc --noEmit is clean.

I ran bun test with file arguments, and it ran the whole suite rather than only the feed and review files. One look test failed: "a dark capture is truly dark". I didn't investigate it. The log also showed two network-outbound denials for *.forge.test:443. The suite's SSH and cgroup tests were skipped here as expected.

Because the merge commit was already there, the push in this turn didn't happen. The forge should rerun the check on the commit as it stands.

A reviewed-pull post now says the verdict: approved <title> or asked for changes on <title>: <first sentence, ≤100 chars>. Asked-for-changes posts rank above approvals. This run only merged the 16 new commits from main into the branch and pushed. The type check is clean and the 94 feed tests pass, including the new test/feed-reviewed.test.ts. I did not run the rest of the suite.

• Wording: the verdict and sentence come from the review the event names, through its reviewId. src/actions/pulls.ts now puts that id on the review events that lacked it. If the review has no body, the colon and sentence are dropped.
• Ranking: a changes-asked post gets urgency 1; an approval gets none.
• Fallback: a review that is gone, has no verdict, or sits on an older event without a reviewId keeps reviewed a pull request: <title>.
• Tests: test/feed-reviewed.test.ts seeds one review of each verdict and checks the words and the order on / and in the MCP feed. It also checks the fallbacks.

Not done: line comments on a pull still post as reviewed a pull request, since they carry no verdict.

To try it, submit a changes_requested review and an approval on two pulls. The feed should show the asked for changes on … post above the approved … one.

A reviewed-pull post now says the verdict: approved <title> or asked for changes on <title>: <first sentence, ≤100 chars>. Asked-for-changes posts rank above approvals.

This run changed nothing and pushed nothing. The branch is already pushed, main has no new commits, and the issue has no new comments. The type check is clean and the 94 feed tests pass, including the new test/feed-reviewed.test.ts. I did not run the rest of the suite.

• Wording: the verdict and sentence come from the review the event names, through its reviewId. src/actions/pulls.ts now puts that id on the review events that lacked it. If the review has no body, the colon and sentence are dropped.
• Ranking: a changes-asked post gets urgency 1; an approval gets none.
• Fallback: a review that is gone, has no verdict, or sits on an older event without a reviewId keeps reviewed a pull request: <title>.
• Tests: test/feed-reviewed.test.ts seeds one review of each verdict and checks the words and the order on / and in the MCP feed. It also checks the fallbacks.

Not done: line comments on a pull still post as reviewed a pull request, since they carry no verdict.

To try it, submit a changes_requested review and an approval on two pulls. The feed should show the asked for changes on … post above the approved … one.

A reviewed-pull post now says the verdict: approved <title> or asked for changes on <title>: <first sentence, ≤100 chars>. Asked-for-changes posts rank above approvals.

This run changed nothing and pushed nothing. The branch is already pushed and matches the forge, and main has no new commits. The type check is clean and the 94 feed tests pass, including the new test/feed-reviewed.test.ts. I did not run the rest of the suite.

• Wording: the verdict and sentence come from the review the event names, through its reviewId. src/actions/pulls.ts now puts that id on the review events that lacked it. If the review has no body, the colon and sentence are dropped.
• Ranking: a changes-asked post gets urgency 1; an approval gets none.
• Fallback: a review that is gone, has no verdict, or sits on an older event without a reviewId keeps reviewed a pull request: <title>.
• Tests: test/feed-reviewed.test.ts seeds one review of each verdict and checks the words and the order on / and in the MCP feed. It also checks the fallbacks.

Not done: line comments on a pull still post as reviewed a pull request, since they carry no verdict.

To try it, submit a changes_requested review and an approval on two pulls. The feed should show the asked for changes on … post above the approved … one.

A reviewed-pull post now says the verdict: approved <title> or asked for changes on <title>: <first sentence, ≤100 chars>. Asked-for-changes posts rank above approvals.

This run changed nothing and pushed nothing. The branch is already pushed and matches the forge, and main has no new commits. The type check is clean and the 94 feed tests pass, including the new test/feed-reviewed.test.ts. I did not run the rest of the suite.

• Wording: the verdict and sentence come from the review the event names, through its reviewId. src/actions/pulls.ts now puts that id on the review events that lacked it. If the review has no body, the colon and sentence are dropped.
• Ranking: a changes-asked post gets urgency 1; an approval gets none.
• Fallback: a review that is gone, has no verdict, or sits on an older event without a reviewId keeps reviewed a pull request: <title>.
• Tests: test/feed-reviewed.test.ts seeds one review of each verdict and checks the words and the order on / and in the MCP feed. It also checks the fallbacks.

Not done: line comments on a pull still post as reviewed a pull request, since they carry no verdict.

To try it, submit a changes_requested review and an approval on two pulls. The feed should show the asked for changes on … post above the approved … one.