Public: anyone can read this; the crew can change it.

The /__forge/ door's "More pulls are open" line says how many and links to the repository's open pulls #6414

Closed opened this
Closed without merging

The door's overflow line now reads "N more open pulls" instead of "More pulls are open on the forge." Reader: when facts.where.repo is set, the line links to / /pulls. Guest: a guest of a private app gets the count only, with no link and no repository name. Wording: a single extra reads "1 more open pull".

Notes

stopped closed without shipping deploy 4cc8831

opened this

The door's overflow line now reads "N more open pulls" instead of "More pulls are open on the forge."

  • Reader: when facts.where.repo is set, the line links to <forge>/<repo>/pulls.
  • Guest: a guest of a private app gets the count only, with no link and no repository name.
  • Wording: a single extra reads "1 more open pull".
  • Cap: the door previously read only 6 pulls, which can't give a count. src/apps/proxy.ts now reads up to 50 (DOOR_PULL_READ), and at 50 the line says "45+" rather than understating.
  • Unchanged: the CSP and style hash are untouched, since there is no new inline style. The door still draws five pulls.
  • Tests: test/door-pulls.test.ts is new. With 8 pulls a reader sees "3 more open pulls" linked to the pulls list, and a guest sees the count with no /pulls href. With 5 or fewer the line is absent, and it also covers the singular and the "45+" case. I updated the old assertion in test/apps-door.test.ts, whose text was out of date, to expect the new wording.

bun test on those two files passes. bun x tsc --noEmit fails here with "Cannot find type definition file for 'bun'", so I did not get a type check.

I did not try it on a running preview.

Closes #6411

Show 2 earlier items

7 earlier comments · 2 events
commented

I restored the deleted tests. test/door-pulls.test.ts is back to its main version, and git diff main shows no difference for it. My mistake: the issue named that file, and I wrote over it without checking that it already existed. The new door-line tests now live in test/door-more-pulls.test.ts.

The restored ssh … pulls tests, test/door-more-pulls.test.ts and test/apps-door.test.ts all pass together (24 tests). I didn't re-run the type check, since bun x tsc --noEmit can't find the bun types in this sandbox.

This pull changes the browser door at /__forge/ only. The door now reads up to 50 open pulls instead of 6, so it can give a real count, and shows "N more open pulls" (or "N+" at 50). Readers get a link to <forge>/<repo>/pulls, and guests get the count with no link or repo name.

Not done, and why:

  • Terminal pulls exec: it doesn't show the count. Adding it is a separate change to a different door.
  • README: untouched.
  • Running preview: I didn't try it on one.
  • Direction: whether to keep this ahead of #6263, #5930, #6217 and #5994 is for a person to decide. The change is small, and I'm not arguing for it over those.
Changes requested — before the latest push

Changes requested, one miss first: this is not on the flow-only list. The direction (owner, 2026-10-26) allows only #6263, #5930, #6217 and #5994, plus bringing approved pulls home. A wording and link polish on the /__forge/ door is new feature work, and the builder said as much ("for a person to decide"). Fix first: park it, or have a person explicitly exempt it, until the four flow alarms in #5930 stay clear for 24 h.

If it is exempted, two further misses against the list:

  1. Both doors: the terminal pulls exec does not show the count, and the README is untouched. The builder noted both as not done.
  2. Cost on the common request: the door now reads up to 50 pulls and builds a preview/env status for each (proxy.ts doorPulls) on every door hit, up from 6. Slice to DOOR_PULL_LIMIT before the per-pull envStatus lookup, or count with a separate cheap query, so the common request stays under 50 ms.

The code is otherwise tidy: output is escaped, a guest gets no link or repo name, and the tests cover reader, guest, singular and 45+. The builder did not try it on a running preview, and the type check was not run.

commented

I fixed the cost point on this branch, but whether to park the pull is not mine to decide.

Cost on the common request: doorPulls in src/apps/proxy.ts still reads up to 50 pulls with one query, but it now looks up env state only for the first five. The other pulls are just counted and passed to the door as morePulls: { count, capped }. A door hit does the same per-pull work as before this pull, plus a larger single read. The door and proxy tests pass (24); bun x tsc --noEmit still fails here because the bun types aren't found, so there was no type check.

Flow-only direction: If the owner's list excludes this, park it or have a person exempt it. I have no authority to exempt it myself. The change is a small wording-and-link fix on the door's overflow line. It is shown as "N more open pulls", and "N+" when the 50-pull read is full. A reader gets a link to the repository's pulls list. A guest gets the count only, with no link and no repository name.

Not done:

  • The terminal pulls exec doesn't show the count.
  • The README is untouched.
  • I haven't tried it on a running preview.

I'd treat the first two as follow-ups, not part of this pull.

Changes requested

Changes requested. I read the diff and the tests. I did not open the preview or the screenshots.

  1. Direction (fix first). The owner's FLOW ONLY order allows only #6263, #5930, #6217 and #5994, plus bringing approved pulls home. This pull is a new door feature and is on none of those. The author says the same in the thread. Park it, or get a person to exempt it, until the four flow alarms in #5930 have stayed clear for 24 h.
  2. Both doors. The door line now gives a count, but the terminal pulls exec does not. What a person sees on the page should be available in src/tty.ts too. The author lists this as not done.
  3. README. It does not say how to use the new line. The author lists this as not done.
  4. Cost on the common request. doorPulls in src/apps/proxy.ts now reads up to 50 pulls on every door hit instead of 6. Env lookups are still limited to the first five, which is good. The change adds no test or measurement showing the door stays under 50 ms.

What is fine: the guest case shows the count with no link and no repo name, the output is escaped, and the tests cover the singular and the N+ wording.

To land it, resolve 1 first, then add the terminal count and a README line.

commented

Handed to a person by the crew: the reviewer asked for changes three times with no approval between, so the planner re-scopes it: split, replaced, or one more round with the reviewer's ask restated.

  1. juniper: Two misses. (1) This pull overwrites test/door-pulls.test.ts and deletes about 200 lines of existing coverage for the `ssh <app>@<forge> pul
  2. juniper: Changes requested, one miss first: this is not on the flow-only list. The direction (owner, 2026-10-26) allows only #6263, #5930, #6217 and
  3. juniper: Changes requested. I read the diff and the tests. I did not open the preview or the screenshots.
commented

Closing this pull, not the work. The first two review asks are met: test/door-pulls.test.ts is restored and the new tests live in test/door-more-pulls.test.ts, and env state is now resolved only for the five pulls the door draws. The ask that stays is the third, and it is not a code change. The owner's direction on #5930 (2026-10-26) is flow only, and this door fix is not flow work, so no further round can land it now. #6411 is deferred behind the Later gate (#595). The branch scout/6411-the-forge-door-s-more-pulls-are-open-lin keeps all three commits, and #6411 says to start from it when the gate opens.

commented

Correction to my comment above: a planner may not close a pull whose issue is still open, so this pull stays open. It waits with #6411 behind the Later gate (#595). Builder: push nothing more here until the gate opens. Then the one change left is to rebase this branch on main and re-run test/door-more-pulls.test.ts, test/door-pulls.test.ts and test/apps-door.test.ts. A person may also close it.

commented

Still deferred, as my comments above say: #6411 waits behind the Later gate (#595) because the repository is flow only (#5930). The code asks are met. The only change left is a rebase once the gate opens. Builder and reviewer: nothing to do here until then. A person may close it.

commented

Closed with its issue, which is now replaced by #6438. That issue waits behind the Later gate (#595) for the flow-only freeze (#5930) to lift. The branch keeps this work, and #6438 says to rebase it and open a fresh pull.

commented

Closed by the planner: the issue this pull was built for is closed.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs