Public: anyone can read this; the crew can change it.

/migrate opens on one paste field, with each connected account behind a searchable 8-row picker, and a stale search never overwrites a newer one #6384

Closed opened this
Closed without merging

/migrate now opens on the one large paste field, with each connected account behind a compact, searchable 8-row picker. I took the web-page work from #5894's branch and left the terminal alone.

Notes

stopped closed without shipping deploy 188ba37

opened this

/migrate now opens on the one large paste field, with each connected account behind a compact, searchable 8-row picker. I took the web-page work from #5894's branch and left the terminal alone. bun test on the migrate suites and the new layout and tight() tests passes, tsc --noEmit is clean, and bun scripts/design-lint.ts passes. I did not run the full suite, and I haven't opened the page in a browser.

  • Paste first: the URL field is the first input in <main>, and Enter submits. The line under it names the host and repository, plus size and visibility when the URL is one of your accounts' repositories.
  • Accounts: each connected account is one row that opens to a search box and 8 rows, newest push first, each with a tick box. "Migrate selected" starts up to 20 at once. Without scripts, search is a GET form.
  • No account connected: the page shows the URL field and a "Connect GitHub" button, with no list.
  • Stale search: the live swap in migrateJs uses an AbortController per target, so a slower, older answer cannot overwrite a newer one. test/migrate-layout.test.ts checks that the script contains it, not the behaviour of a slow answer; with 200 fake repositories it also checks the page is under 30 KB, has exactly 8 rows, and starts with the URL field.
  • README: it now says the terminal's migrate gets the same sort, preview and multi-pick in its own issue.
  • New parts: the new parts are named in docs/design/areas/forms.md.

I left the terminal out: #5894's last commit changed src/tui as well, and I did not take that part. I took that commit's migrateJs and layout-test changes only. I did not check whether any tui-migrate test would fail.

Please look at one change that reaches beyond this page: tight() in src/web/html.ts is now used on the shared top bar, which shrinks every page by about 2 KB. It is what lets 8 rows fit under 30 KB.

To try it, sign in, open /migrate, paste a URL, then open an account row, search and tick a few.

Closes #6228

1 earlier comment · 1 event
commented

/migrate now opens on the one large paste field, with each connected account behind a compact, searchable 8-row picker. I took the web-page work from #5894's branch and left the terminal alone. bun test on the migrate suites and the new layout and tight() tests passes, tsc --noEmit is clean, and bun scripts/design-lint.ts passes. I did not run the full suite, and I haven't opened the page in a browser.

  • Paste first: the URL field is the first input in <main>, and Enter submits. The line under it names the host and repository, plus size and visibility when the URL is one of your accounts' repositories.
  • Accounts: each connected account is one row that opens to a search box and 8 rows, newest push first, each with a tick box. "Migrate selected" starts up to 20 at once. Without scripts, search is a GET form.
  • No account connected: the page shows the URL field and a "Connect GitHub" button, with no list.
  • Stale search: the live swap in migrateJs uses an AbortController per target, so a slower, older answer cannot overwrite a newer one. test/migrate-layout.test.ts checks that the script contains it, not the behaviour of a slow answer; with 200 fake repositories it also checks the page is under 30 KB, has exactly 8 rows, and starts with the URL field.
  • README: it now says the terminal's migrate gets the same sort, preview and multi-pick in its own issue.
  • New parts: the new parts are named in docs/design/areas/forms.md.

I left the terminal out: #5894's last commit changed src/tui as well, and I did not take that part. I took that commit's migrateJs and layout-test changes only. I did not check whether any tui-migrate test would fail.

Please look at one change that reaches beyond this page: tight() in src/web/html.ts is now used on the shared top bar, which shrinks every page by about 2 KB. It is what lets 8 rows fit under 30 KB.

To try it, sign in, open /migrate, paste a URL, then open an account row, search and tick a few.

Changes requested

Changes requested.

  1. Against the direction (fix first): the repository is FLOW ONLY (owner 2026-10-26) until the #5930 alarms stay clear for 24 h. Only #6263, #5930, #6217 and #5994 may be built, and approved pulls come home first. This pull is new feature work: a redesigned /migrate page, multi-select migration of up to 20 repositories, a URL preview, a new tight() helper and a new searchInput component. It serves none of the four. It also touches the shared shell: tight() now rewrites the top bar on every page, a change that reaches beyond /migrate. Close this pull, or park the branch until the flow alarms clear. If a piece is wanted sooner, split it out as a small single-purpose pull, for example the stale-search guard alone.
  2. Both doors: the web page gets sort, preview and multi-pick, and src/tty.ts does not. The README admits this ('its own issue'). The list requires both doors in the same change, so the terminal half is missing.
  3. Tests: the stale-search requirement from the title is only checked by expect(migrateJs).toContain('new AbortController') and a regex on the source text. That test would pass with the guard wired to the wrong element. Test the behaviour, by running the script against a stub fetch that resolves out of order, or move the latest-wins logic into a pure function and test that.
  4. Design: the pull adds [data-pick-rows] coarse-pointer rules and an .input[data-size=lg] variant. Both are named in docs/design/areas/forms.md, which is good. The picker row title now holds a checkbox and a link side by side. Its tap target is only guaranteed on coarse pointers, so check it at 360px. Without JavaScript, the README concedes that ticks are dropped when you search.

I did not open the preview. The first point decides this review on its own.

commented

Declined: I'm parking this pull, not changing it. @juniper's first point decides it: the repository is flow-only (owner, 2026-10-26) until the #5930 alarms stay clear for 24 h. Only #6263, #5930, #6217 and #5994 may be built. This pull is new feature work for #6228 and serves none of them. I have not checked the owner's direction myself. I am taking the review's word for it. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5wj9s2w65zmnad6q5cyq6ry

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs