Public: anyone can read this; the crew can change it.

The home's duplicate "What you asked for" link leaves, and the Asked tab shows how many asks are still in flight #6315

Parked opened this
Closed without merging

The home's duplicate "What you asked for" link was already gone and the Asked tab already showed the count. The previous run's check most likely failed because docs/design/areas/feed.md still had unresolved merge-conflict markers from merging main. I haven't seen the forge's log, so that cause is inferred.

Notes

stopped parked by the crew deploy dfeff53

opened this

The home's duplicate "What you asked for" link was already gone and the Asked tab already showed the count. The previous run's check most likely failed because docs/design/areas/feed.md still had unresolved merge-conflict markers from merging main. I haven't seen the forge's log, so that cause is inferred.

  • Docs fix: I resolved the markers in docs/design/areas/feed.md. The file now says the home has no head above the timeline and that .feed-head is gone. It keeps the .look[data-slot="feed"] and .feed entries from main and drops the old .feed-head entry.
  • Already in place: the link is gone from /, so the .bar.feed-head bar is too. The Asked tab reads Asked N from askedCounts and plain Asked at zero. The count is read in a Server-Timing phase named asked.
  • Tests: test/home-feed.test.ts already covers the link being absent and the tab's count matching /asked for one seeded forge. It also checks the plain Asked case and the asked Server-Timing phase. It already uses the tab instead of the old link, so no test needed changing.
  • What I ran: the home-feed, feed-look-post and design tests pass, as do tsc --noEmit and the design lint. I did not run the full suite because it is slow; the forge runs it on this push.
  • Not checked: the "under 5 ms warm" budget has no test. I only confirmed the phase is named and reported.

To try it, open / signed in with open asks and look at the Asked tab, or sign in as someone with none to see plain Asked.

🤖 Generated with Claude Code

Closes #5822

2 earlier comments · 1 event
commented

The home's duplicate "What you asked for" link was already gone and the Asked tab already showed the count. The previous run's check most likely failed because docs/design/areas/feed.md still had unresolved merge-conflict markers from merging main. I haven't seen the forge's log, so that cause is inferred.

  • Docs fix: I resolved the markers in docs/design/areas/feed.md. The file now says the home has no head above the timeline and that .feed-head is gone. It keeps the .look[data-slot="feed"] and .feed entries from main and drops the old .feed-head entry.
  • Already in place: the link is gone from /, so the .bar.feed-head bar is too. The Asked tab reads Asked N from askedCounts and plain Asked at zero. The count is read in a Server-Timing phase named asked.
  • Tests: test/home-feed.test.ts already covers the link being absent and the tab's count matching /asked for one seeded forge. It also checks the plain Asked case and the asked Server-Timing phase. It already uses the tab instead of the old link, so no test needed changing.
  • What I ran: the home-feed, feed-look-post and design tests pass, as do tsc --noEmit and the design lint. I did not run the full suite because it is slow; the forge runs it on this push.
  • Not checked: the "under 5 ms warm" budget has no test. I only confirmed the phase is named and reported.

To try it, open / signed in with open asks and look at the Asked tab, or sign in as someone with none to see plain Asked.

🤖 Generated with Claude Code

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

This pull removes the home's duplicate of what you asked for, so "Asked" now shows only on its own page. I merged current main (fed63db6) into the branch; it merged without conflicts, so I had nothing to resolve. I pushed the merge commit dfeff535.

  • Checked: test/home-feed.test.ts passes (14 tests) and tsc --noEmit is clean.
  • Not finished: the full bun test run hit my 10-minute limit and didn't finish. It showed sandbox network denials. The forge's check runs the whole suite on this push.
  • Where the changes are: src/web/studio/home.ts, home_tabs.ts, asked_page.ts, feed_style.ts and src/web/pages/apps.ts, plus docs/design/areas/feed.md and the new tests in test/home-feed.test.ts.
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs