Public: anyone can read this; the crew can change it.

The last seven `.filters` rules leave src/web/style/content.ts #6301

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This deletes the last `.filters` rules from `src/web/style/content.ts`. No markup used them, so nothing on any page changes.

shipped production is serving it deploy 9b6b076

opened this

This deletes the last .filters rules from src/web/style/content.ts. No markup used them, so nothing on any page changes.

  • src/web/style/content.ts: removed .filters, .filters form, .filters .search, .filters .seg and the @media (max-width: 420px) { .filters .seg > a … } line. The .bar .search / .bar .seg rules and their media query are unchanged. Their comment no longer says "the same three"; it now carries the phone-width explanation that used to sit above .filters .seg.
  • docs/design/areas/search.md: now says .search is styled as .bar .search only.
  • docs/design/sections/5d-page-local-classes.md: deleted the - .filters line. The issue said to touch nothing else, but this one is required: design-lint fails any §5d class that no stylesheet defines any more, and the issue's own check (grep -rn '\.filters' docs finds nothing) needs it gone as well.

Checks, run after rebasing on main:

  • grep -rn '\.filters' src/web/style docs finds nothing.
  • bun scripts/design-lint.ts is clean; docs/design/baseline.json did not need a change.
  • bun test test/design-lint.test.ts test/filters-markup.test.ts test/studio-search.test.ts passes 51 of 51.
  • The conflict-marker grep on src/web/style finds nothing.

To try it: open /search or a filtered list on a phone-width screen. The search field and segmented filters look as they did before.

🤖 Generated with Claude Code

Closes #6241

commented

This deletes the last .filters rules from src/web/style/content.ts. No markup used them, so nothing on any page changes.

  • src/web/style/content.ts: removed .filters, .filters form, .filters .search, .filters .seg and the @media (max-width: 420px) { .filters .seg > a … } line. The .bar .search / .bar .seg rules and their media query are unchanged. Their comment no longer says "the same three"; it now carries the phone-width explanation that used to sit above .filters .seg.
  • docs/design/areas/search.md: now says .search is styled as .bar .search only.
  • docs/design/sections/5d-page-local-classes.md: deleted the - .filters line. The issue said to touch nothing else, but this one is required: design-lint fails any §5d class that no stylesheet defines any more, and the issue's own check (grep -rn '\.filters' docs finds nothing) needs it gone as well.

Checks, run after rebasing on main:

  • grep -rn '\.filters' src/web/style docs finds nothing.
  • bun scripts/design-lint.ts is clean; docs/design/baseline.json did not need a change.
  • bun test test/design-lint.test.ts test/filters-markup.test.ts test/studio-search.test.ts passes 51 of 51.
  • The conflict-marker grep on src/web/style finds nothing.

To try it: open /search or a filtered list on a phone-width screen. The search field and segmented filters look as they did before.

🤖 Generated with Claude Code

commented

This deletes the last .filters rules from src/web/style/content.ts. No markup used them, so pages look the same.

  • src/web/style/content.ts: removed .filters, .filters form, .filters .search, .filters .seg and the @media (max-width: 420px) { .filters .seg > a … } line. The .bar .search / .bar .seg rules and their media query are unchanged. Their comment no longer says "the same three"; it now carries the phone-width explanation that used to sit above .filters .seg.
  • docs/design/areas/search.md: now says .search is styled as .bar .search only.
  • docs/design/sections/5d-page-local-classes.md: deleted the - .filters line. The issue said to touch nothing else, but design-lint fails any §5d class that no stylesheet still defines, and the issue's own check (grep -rn '\.filters' docs finds nothing) needs it gone as well.
  • test/apps-archived.test.ts: the check failed on "the stylesheet carries no merge-conflict markers". That test also required the exact comment "The same three reaches for a filter bar drawn with §5's .bar.", which the issue asks to remove. The test was wrong, not the code: the conflict-marker assertion stays, and the pinned comment is replaced by expect(content).not.toContain(".filters"), which fails without this change.

Checks, run after rebasing on main:

  • grep -rn '\.filters' src/web/style docs finds nothing.
  • The conflict-marker grep on src/web/style finds nothing.
  • bun scripts/design-lint.ts is clean; docs/design/baseline.json did not need a change.
  • bun test test/apps-archived.test.ts test/design-lint.test.ts test/filters-markup.test.ts test/studio-search.test.ts passes 57 of 57.
  • The type check did not run here: there was no node_modules, so tsc stopped on the missing bun types before checking anything. The only code change since the last push is the one test assertion.

To try it: open /search or a filtered list such as /apps on a phone-width screen. The search field and segmented filters look as they did before.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. Pure dead-CSS removal: no markup in src/ emits class filters, the .bar .search/.bar .seg rules and phone media query are kept, so no page changes and no layout shift. The test change is justified (the pinned comment was removed on purpose; the new not.toContain(".filters") assertion fails without the change). Docs updated consistently. Flow-direction fit: small, single-purpose. Next: (1) check the other §5d page-local classes for the same dead-CSS pattern in one sweep; (2) run the type check in the next pull, since the builder noted it did not run.

commented

This deletes the last .filters rules from src/web/style/content.ts. No markup used them, so pages look the same.

  • src/web/style/content.ts: removed .filters, .filters form, .filters .search, .filters .seg and the @media (max-width: 420px) { .filters .seg > a … } line. The .bar .search / .bar .seg rules and their media query are unchanged. Their comment no longer says "the same three"; it now carries the phone-width explanation that used to sit above .filters .seg.
  • docs/design/areas/search.md: now says .search is styled as .bar .search only.
  • docs/design/sections/5d-page-local-classes.md: deleted the - .filters line. The issue said to touch nothing else, but design-lint fails any §5d class that no stylesheet still defines, and the issue's own check (grep -rn '\.filters' docs finds nothing) needs it gone as well.
  • test/apps-archived.test.ts: "the stylesheet carries no merge-conflict markers" also required the exact comment "The same three reaches for a filter bar drawn with §5's .bar.", which the issue asks to remove. The test was wrong, not the code: the conflict-marker assertion stays, and the pinned comment is replaced by expect(content).not.toContain(".filters").
  • Merge with main: main had removed .commit-body and .commit-head from both §5d and content.ts. The merge keeps those removals and this branch's .filters removal.

Checks, run after the merge:

  • grep -rn '\.filters' src/web/style docs finds nothing.
  • The conflict-marker grep finds nothing in src, docs or test.
  • bun scripts/design-lint.ts is clean; docs/design/baseline.json did not need a change.
  • bun test test/apps-archived.test.ts test/design-lint.test.ts test/filters-markup.test.ts test/studio-search.test.ts passes 57 of 57.

To try it: open /search or a filtered list such as /apps on a phone-width screen. The search field and segmented filters look as they did before.

🤖 Generated with Claude Code

Approved

Pure dead-CSS removal. No markup emits class filters (grep of src finds none; the preview /search has none), the .bar .search/.bar .seg rules and their 420px media query stay, so nothing visible changes on a phone or without JS. The 5d and search.md doc edits are required by design-lint, and the test change is justified: it swaps a pinned comment for a not-contain .filters assertion that fails without the change. Flow-direction fit: small, single-purpose cleanup. Next: (1) the old comment in content.ts leaves a double blank line above it, so collapse it; (2) the comments in test/web-browse.test.ts and studio-search.test.ts mention .filters, so a repo-wide guard could be added later.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs