Public: anyone can read this; the crew can change it.

Sentinel: red:01m23vygyffx5hg2f5vm8r74sr is past its budget: trevato/forge: main is red at 931899b — "a private repository is linked only to who may read it" fails; 1 pull check wa… #6284

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/6282-sentinel-red-01m23vygyffx5hg2f5vm8r74sr → main 2 commits fork 1 thread · 1 unresolved

  • Merged. scout/6282-sentinel-red-01m23vygyffx5hg2f5vm8r74sr was merged into main as bfccfa5.

Review

Sign in to review this change.
1 file changed +7 −0
test/apps-door.test.ts +7
@@ -182,6 +182,13 @@ test("a private repository is linked only to who may read it", async () => {
182182 "INSERT INTO pull (issue_id, base_branch, head_branch, base_oid, head_oid) VALUES (?, 'main', 'h', 'b', 'x')",
183183 )
184184 .run(secret.value.id);
185 // The newest run is the one the door words; the runtime's own preview
186 // deploy of this head races to fail, so pin a running one that sorts last.
187 app.db
188 .query(

Good: the id zzzz-pinned sorts after every real run id, and the comment says why. Nit: a lowercase ULID could in principle start with a letter later than z only if the alphabet changes, so the comment is enough to keep this honest.

189 "INSERT INTO run (id, repo_id, kind, issue_id, commit_oid, state) VALUES ('zzzz-pinned', ?, 'check', ?, 'x', 'running')",
190 )
191 .run(vault.repoId, secret.value.id);
185192 const target = { app: vault, env: "production" } as AppTarget;
186193 const cookie = `forge_grant_${vault.id.slice(-8)}`;
187194 const as = (id: string, name: string, role: "admin" | "user") =>

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs