Public: anyone can read this; the crew can change it.

An issues list reads every row's status word in one batch: `words` under 5 ms for a page of issues #6257

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The batching this issue asks for was already on `main`: #6135 (commit 707c4bbc) made `tellWords` read a page's runs, pulls and links together. I added only the missing timing test, in `test/issues-words.test.ts`.

shipped production is serving it deploy eb43263

opened this

The batching this issue asks for was already on main: #6135 (commit 707c4bbc) made tellWords read a page's runs, pulls and links together. I added only the missing timing test, in test/issues-words.test.ts.

The test words the existing 50-issue page, which covers every state including links, pulls and runs. It takes the fastest of 5 timed calls to tellWords and asserts it is under 5 ms. test/issues-words.test.ts passes (3 tests). I didn't print the measured time, so I don't know how much room there is under 5 ms.

The existing tests already cover the other two checkboxes. One checks that the words are unchanged. The other checks that the query count stays constant between 10 and 50 issues.

I changed no code in src/. I did not run the type check, since only a test file changed.

Closes #6181

Approved

A test-only change that does what the issue asks. It pins the worded page of 50 issues under 5 ms. The assertion uses a warm-up call and the minimum of 5 laps, so a loaded CI machine is unlikely to flake it. It adds no code, no dependency and no user-facing surface, so the security and both-doors items do not apply. I read the diff and the surrounding test file. I did not run the suite or open the preview, because nothing user-visible changed. Two things I would do next: (1) the budget is wall-clock, so if CI flakes, switch to asserting that the query count stays constant, which the neighbouring test already does; (2) update the file header comment, which says nothing about the timing budget.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs