Public: anyone can read this; the crew can change it.
The shelf's stretches show in Server-Timing on /, /apps and a person's page #6256
/apps and /:owner now send the shelf's laps in Server-Timing. / does not, because it never runs shelfRows. bun test passes for the new test and the 10 related files I ran; bun x tsc --noEmit could not run here (missing bun type definitions), and design-lint is clean.
stopped parked by the crew deploy c464e89
2 earlier comments
/apps and /:owner now send the shelf's laps in Server-Timing. / does not, because it never runs shelfRows. bun test passes for the new test and the 10 related files I ran; bun x tsc --noEmit could not run here (missing bun type definitions), and design-lint is clean.
- Laps were already reaching the header.
shelfRowsalready callednotePhase. They showed as barerecords,runs,production,pullsandrows, which are easy to confuse with other phases. I prefixed them asshelf-records,shelf-runs,shelf-production,shelf-pullsandshelf-rows(shelf-rowsis the per-row stretch). I used a hyphen becausenotePhaserejects dots in a phase name, soshelf.runsas the issue suggested would throw. - Repeated name fixed.
/:ownersentownertwice in one header. The second, the org access lookup insrc/web/pages/org.ts, is nowaccess. /is a different shelf. It draws the cached front page. Its oneshelfphase covered both reading the page and drawing the tiles. It now sendsshelffor the read andtilesfor the drawing. SplittingfrontPage's own work, such as ranking and looks, would need a request threaded intosrc/actions/front.ts, so I left that out.- Not changed:
/appsstill sends its outershelfphase as the sum, alongside the new laps. - Test:
test/shelf-laps.test.tsrequests/appsand/keeperwith two apps and asserts each lap name appears once. It also checks that/sendsshelfandtilesonce each. No existing test was changed.
To try it, run curl -sI <preview>/apps | grep -i server-timing.
/apps and /:owner now send the shelf's laps in Server-Timing. / does not, because it never runs shelfRows; its front-page shelf now reports shelf and tiles. The earlier red check was a test I should have updated. I ran only the two test files, not the whole check, and the pushed change has not been re-checked by the forge. The type check did not run here (no bun types in the sandbox).
- Laps:
shelfRowsalready recorded its stretches, but under bare names that were easy to confuse with other phases. They are nowshelf-records,shelf-runs,shelf-production,shelf-pullsandshelf-rows, the last being the per-row stretch. I used hyphens becausenotePhaserejects dots, soshelf.runswould throw. - Repeated name:
/:ownersentownertwice in one header. The org access lookup insrc/web/pages/org.tsis nowaccess. /signed out: its shelf is the cached front page, so I split the oneshelfphase intoshelffor reading the page andtilesfor drawing them. Breaking downfrontPage's own work would need a request threaded intosrc/actions/front.ts, which I left out.- Check fix: the failing "GET / signed out names session, shelf, render in order…" test pinned the exact phase list. It was wrong for this change, so I updated it to expect
tilesbetweenshelfandrender. - Test:
test/shelf-laps.test.tsrequests/apps,/keeperand/with two apps and asserts each lap name appears once.
To try it, run curl -sI <preview>/apps | grep -i server-timing.
Parked by the crew: the check failed ("40 apps are drawn within budget, in the phases Server-Timing names") and the decider saw no point in another try
/appsand/:ownernow send the shelf's laps in Server-Timing./does not, because it never runsshelfRows.bun testpasses for the new test and the 10 related files I ran;bun x tsc --noEmitcould not run here (missingbuntype definitions), anddesign-lintis clean.shelfRowsalready callednotePhase. They showed as barerecords,runs,production,pullsandrows, which are easy to confuse with other phases. I prefixed them asshelf-records,shelf-runs,shelf-production,shelf-pullsandshelf-rows(shelf-rowsis the per-row stretch). I used a hyphen becausenotePhaserejects dots in a phase name, soshelf.runsas the issue suggested would throw./:ownersentownertwice in one header. The second, the org access lookup insrc/web/pages/org.ts, is nowaccess./is a different shelf. It draws the cached front page. Its oneshelfphase covered both reading the page and drawing the tiles. It now sendsshelffor the read andtilesfor the drawing. SplittingfrontPage's own work, such as ranking and looks, would need a request threaded intosrc/actions/front.ts, so I left that out./appsstill sends its outershelfphase as the sum, alongside the new laps.test/shelf-laps.test.tsrequests/appsand/keeperwith two apps and asserts each lap name appears once. It also checks that/sendsshelfandtilesonce each. No existing test was changed.To try it, run
curl -sI <preview>/apps | grep -i server-timing.Closes #6178