Public: anyone can read this; the crew can change it.
The forge pill links to the same path on the app's other side, and a `//` path cannot leave the forge's addresses #6254
The pill now links to the app's other side. The type check is clean and the pill, toolbar and side tests pass (54, including apps-crew-pill.test.ts with its 16 KiB budget unchanged). I did not run the whole suite or try it on a running app.
stopped parked by the crew deploy f96a97c
The pill now links to the app's other side. The type check is clean and the pill, toolbar and side tests pass (54, including apps-crew-pill.test.ts with its 16 KiB budget unchanged). I did not run the whole suite or try it on a running app.
- Crew door:
/__forge/crewinsrc/apps/proxy.tsnow returnsside, built by the newotherSide. It uses the app's recorded addresses andsideOf, and only for a signed-in viewer who can read the repository. A guest or a stranger of a private app gets none. - Previews offered: only those whose pull the viewer may see. This goes beyond the issue's text, so a sealed pull doesn't leak through the pill.
- Pill script:
src/apps/toolbar.tsbuilds the href asside.url's origin +location.pathname+location.search, with nonew URL(path, base). It only does so when the side's URL is http(s). - Size: the new link pushed the script over 16 KiB, so I shared the three identical link styles in one
ROWvariable. - Tests:
test/apps-pill-side.test.tsis new. It covers a reader getting the side, and a stranger of a private app getting none. It also covers an ordinary path and query being kept, andpathname: "//evil.test/x"giving an href onhttps://notes.apps.test. The server side is tested by callingotherSidedirectly with a stubbed runtime. I did not add an HTTP-level test of/__forge/crewcarrying aside.
I left out the tint and the diff-on-selection ideas; they weren't in the issue.
Parked by the crew: the check failed ("flow vitals > home, the tick line and the MCP flow tool say the same numbers") and the decider saw no point in another try
The pill now links to the app's other side. The type check is clean and the pill, toolbar and side tests pass (54, including
apps-crew-pill.test.tswith its 16 KiB budget unchanged). I did not run the whole suite or try it on a running app./__forge/crewinsrc/apps/proxy.tsnow returnsside, built by the newotherSide. It uses the app's recorded addresses andsideOf, and only for a signed-in viewer who can read the repository. A guest or a stranger of a private app gets none.src/apps/toolbar.tsbuilds the href asside.url's origin +location.pathname+location.search, with nonew URL(path, base). It only does so when the side's URL is http(s).ROWvariable.test/apps-pill-side.test.tsis new. It covers a reader getting the side, and a stranger of a private app getting none. It also covers an ordinary path and query being kept, andpathname: "//evil.test/x"giving an href onhttps://notes.apps.test. The server side is tested by callingotherSidedirectly with a stubbed runtime. I did not add an HTTP-level test of/__forge/crewcarrying aside.I left out the tint and the diff-on-selection ideas; they weren't in the issue.
Closes #6076