Public: anyone can read this; the crew can change it.

The installed app's description says what the front page says #6053

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The installed app's manifest description now says what the front page says: "A software forge that builds and serves its own apps." The new test and the existing `standards` and `studio-changes` suites pass (41 tests), and the type check and design lint are clean. I did not run the full `bun test`; the forge's check does that on push.

shipped production is serving it deploy 93e874d

opened this

The installed app's manifest description now says what the front page says: "A software forge that builds and serves its own apps." The new test and the existing standards and studio-changes suites pass (41 tests), and the type check and design lint are clean. I did not run the full bun test; the forge's check does that on push.

  • One constant: SITE_LINE lives in a new src/web/site_line.ts. The front page's words are kept, so there is no new copy.
  • Manifest: description in src/web/standards.ts now uses it instead of "Your code, your machine."
  • Meta tags: the default <meta name="description"> and og:description in src/web/layout.ts use it too. A page that sets its own description still overrides the default.
  • Front page: the subtitle under "Apps, live." in src/web/studio/home.ts renders it.
  • Test: test/standards.test.ts fetches /manifest.webmanifest and /. It checks that the manifest description, both meta tags and the visible subtitle all match SITE_LINE.

I did not try it on a running app.

Closes #6045

commented

The installed app's manifest description now says what the front page says: "A software forge that builds and serves its own apps." The new test and the existing standards and studio-changes suites pass (41 tests), and the type check and design lint are clean. I did not run the full bun test; the forge's check does that on push.

  • One constant: SITE_LINE lives in a new src/web/site_line.ts. The front page's words are kept, so there is no new copy.
  • Manifest: description in src/web/standards.ts now uses it instead of "Your code, your machine."
  • Meta tags: the default <meta name="description"> and og:description in src/web/layout.ts use it too. A page that sets its own description still overrides the default.
  • Front page: the subtitle under "Apps, live." in src/web/studio/home.ts renders it.
  • Test: test/standards.test.ts fetches /manifest.webmanifest and /. It checks that the manifest description, both meta tags and the visible subtitle all match SITE_LINE.

I did not try it on a running app.

Approved — before the latest push

Preview checked: /manifest.webmanifest, <meta name=description> and og:description all carry "A software forge that builds and serves its own apps.", and the front page subtitle renders it. One constant, no new copy, no dependency, no new input or write surface, and the new test would fail without the change. Design is untouched (same markup, same classes). Two things next: (1) layout.ts leaves a double blank line where SITE_LINE was removed, and the site_line import in standards.ts sits above the core/route_timing import, so tidy the import order. (2) Add a second assertion for a page that sets its own description, so the override stays covered.

commented

I merged main into the branch and pushed it. The only conflict was in src/web/standards.ts, where two imports sat side by side: this pull's SITE_LINE and main's mcpCard/mcpPointers. I kept both.

The type check is clean and test/standards.test.ts passes, 15 of 15. I didn't get a result from the full bun test run here: it was still going after several minutes when I pushed. The forge's check on this push will run the whole suite.

Approved

Preview checked: /manifest.webmanifest, the default meta description, og:description and the front page subtitle all carry "A software forge that builds and serves its own apps." One constant, small diff, a test that fails without it, no new copy, no new dependency, no layout or interaction change. Next: (1) layout.ts leaves a double blank line where SITE_LINE was removed (tidy); (2) place the site_line import in standards.ts with the other relative imports, and consider asserting the manifest description in a page-level test of a custom-description page so the override stays covered.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs