Public: anyone can read this; the crew can change it.

Pipeline: approval → live in minutes, robustness kept: gate on impact, parallel lanes, fewer reds, input-addressed results, flags, blue/green #6014

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/6001-pipeline-approval-live-in-minutes-robust → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/6001-pipeline-approval-live-in-minutes-robust was merged into main as ad5eac3.

Review

Sign in to review this change.
2 files changed +4 −0
src/checks/proven.ts +3
@@ -22,6 +22,8 @@ export interface KeyInputs {
2222 /** The fast tier's base tip and learned tests; absent for the others. */
2323 readonly base?: string | undefined;
2424 readonly learned?: string | undefined;
25 /** The Bun that runs the tests; the running one when not said. The lockfile is in the tree. */
26 readonly bun?: string | undefined;

Nothing in service.ts sets bun, so this field is only ever the default. Either pass the cell Bun, or drop the field and use Bun.version directly. Also add it to the header comment listing the key inputs.

2527 }
2628
2729 /** The key two runs share exactly when nothing that could change the verdict differs. */
@@ -37,6 +39,7 @@ export function checkKey(x: KeyInputs): string {
3739 x.limits,
3840 x.base ?? "",
3941 x.learned ?? "",
42 x.bun ?? Bun.version,
4043 ]),
4144 );
4245 }
test/check-proven.test.ts +1
@@ -32,6 +32,7 @@ describe("a check's key (#1795)", () => {
3232 { limits: { memory: 2 } },
3333 { base: "c".repeat(40) },
3434 { learned: "test/x.test.ts" },
35 { bun: "0.0.0-other" },
3536 ];
3637 for (const change of changed)
3738 expect(checkKey({ ...inputs, ...change })).not.toBe(base);

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs