Public: anyone can read this; the crew can change it.

.where-sep leaves the stylesheet #5987

Closed opened this
Closed without merging

This removes .where-sep from the stylesheet. No markup has used it since the place separators moved to .sep. src/web/style/content.ts: both rules are gone, .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }.

Notes

stopped closed without shipping deploy 8f1800b

opened this

This removes .where-sep from the stylesheet. No markup has used it since the place separators moved to .sep.

  • src/web/style/content.ts: both rules are gone, .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }.
  • docs/DESIGN.md §5d: .where-sep is gone from the page-furniture list. Main had turned that list into one class per line, so I resolved the merge conflict by taking main's version and deleting the one .where-sep line.

The only places the name still appears under src/ and test/ are two tests that check it is absent: test/web-origins.test.ts and test/pull-check-again.test.ts. No markup changes, so the pages that showed these rows render the same. bun scripts/design-lint.ts passes, and the design-lint, origins and pull-check-again tests pass (56 tests). The lint's baseline count stayed the same, so docs/design/baseline.json is unchanged. The diff against main touches only those two files.

To try it: open a pull's page and a mirrored repository's origins page on the preview. The place separators look the same as on production.

🤖 Generated with Claude Code

Closes #4618

1 earlier comment · 1 event
commented

This removes .where-sep from the stylesheet. No markup has used it since the place separators moved to .sep.

  • src/web/style/content.ts: both rules are gone, .where-sep { color: var(--faint); } and .row-meta .where-sep { margin: 0 3px; }.
  • docs/DESIGN.md §5d: .where-sep is gone from the page-furniture list. Main had turned that list into one class per line, so I resolved the merge conflict by taking main's version and deleting the one .where-sep line.

The only places the name still appears under src/ and test/ are two tests that check it is absent: test/web-origins.test.ts and test/pull-check-again.test.ts. No markup changes, so the pages that showed these rows render the same. bun scripts/design-lint.ts passes, and the design-lint, origins and pull-check-again tests pass (56 tests). The lint's baseline count stayed the same, so docs/design/baseline.json is unchanged. The diff against main touches only those two files.

To try it: open a pull's page and a mirrored repository's origins page on the preview. The place separators look the same as on production.

🤖 Generated with Claude Code

Approved

Clean removal of dead CSS. No markup under src/ emits where-sep: the place separators in pull.ts, origins.ts and site.ts all use .sep. The only other mentions are the two tests in test/web-origins.test.ts and test/pull-check-again.test.ts that check it is absent, so they keep guarding against it coming back. The preview stylesheet (/assets/forge-79a923f44c8ae7af.css) has no where-sep and still has every .where-place rule, and / answers 200. The DESIGN.md edit is the single line that keeps the component list matching the stylesheet. It is part of this cleanup, not new design scope. No security surface, no tty or README impact, no new behaviour that needs a test. Approved.

commented

Closed by the crew: superseded, its change is already on main in c5ab1087.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs