Public: anyone can read this; the crew can change it.

.bmanage leaves the stylesheet #5982

Closed opened this
Closed without merging

This removes the unused .bmanage class: its rule is gone from src/web/style/content.ts and its entry is gone from docs/DESIGN.md §5d. No markup under src/ draws it. The diff against main is two deleted lines, one in each file.

Notes

stopped closed without shipping deploy dfc0eab

opened this

This removes the unused .bmanage class: its rule is gone from src/web/style/content.ts and its entry is gone from docs/DESIGN.md §5d. No markup under src/ draws it. The diff against main is two deleted lines, one in each file.

What to look at:

  • The merge commit. This pull conflicted in docs/DESIGN.md because main now lists §5d's classes one per bullet. I took main's version of the file and deleted only the .bmanage bullet, so nothing else in §5d changes.
  • The test. test/boards-store.test.ts:171 already checks that the boards page shows the manage controls with §5's row and bar, keeps every form, and contains no bmanage. That test is unchanged and passes. It is the only place the name still appears under src/ and test/.
  • The baseline. docs/design/baseline.json is unchanged: the lint passes and no class count it checks dropped.

bun scripts/design-lint.ts passes, and bun test test/design-lint.test.ts test/boards-store.test.ts passes 37 of 37 tests. To try it, open /boards on the preview: the manage controls should look the same as on production.

Closes #4617

🤖 Generated with Claude Code

Closes #4617

1 earlier comment · 1 event
commented

This removes the unused .bmanage class: its rule is gone from src/web/style/content.ts and its entry is gone from docs/DESIGN.md §5d. No markup under src/ draws it. The diff against main is two deleted lines, one in each file.

What to look at:

  • The merge commit. This pull conflicted in docs/DESIGN.md because main now lists §5d's classes one per bullet. I took main's version of the file and deleted only the .bmanage bullet, so nothing else in §5d changes.
  • The test. test/boards-store.test.ts:171 already checks that the boards page shows the manage controls with §5's row and bar, keeps every form, and contains no bmanage. That test is unchanged and passes. It is the only place the name still appears under src/ and test/.
  • The baseline. docs/design/baseline.json is unchanged: the lint passes and no class count it checks dropped.

bun scripts/design-lint.ts passes, and bun test test/design-lint.test.ts test/boards-store.test.ts passes 37 of 37 tests. To try it, open /boards on the preview: the manage controls should look the same as on production.

Closes #4617

🤖 Generated with Claude Code

Approved

Removes the dead .bmanage rule and its DESIGN.md §5d entry. I grepped src/ and test/ and found no markup that draws it. The only remaining mention is the negative assertion at test/boards-store.test.ts:171, which is correct to keep. The change is two deleted lines, it stays inside the direction, and it changes no behaviour. The boards page already uses §5 row and bar, so nothing should shift on a 360px phone or with JavaScript off. Two things I would do next: (1) run design-lint in the check so a class gone from the CSS also has to leave DESIGN.md, which is how this drift started; (2) look for other classes listed in §5d with no markup under src/web.

commented

Closed by the crew: superseded, its change is already on main in c5ab1087.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs