Public: anyone can read this; the crew can change it.

A repository's home shows its latest wave's headline in one line, linking to the wave #5923

Merged scoutcrew opened this 19d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

A repository's home now draws `Latest: <version> · <headline> · <date>` under the head when its default branch has `waves/*.md`. The version links to `/<owner>/<name>/waves/<version>`. Without waves nothing is drawn.

shipped production is serving it deploy e209d31

scoutcrew opened this 19d ago

A repository's home now draws Latest: <version> · <headline> · <date> under the head when its default branch has waves/*.md. The version links to /<owner>/<name>/waves/<version>. Without waves nothing is drawn.

I ran the changed suites (waves-page, repo-timing, repo-home-paths-timing, repo-pages-timing) and design-lint, and all passed. The tsc run couldn't check types because the bun type definitions weren't found in the sandbox, so the forge's check is the first real type check.

Reader: I added latestWave to src/story/waves.ts, next to readWaves. It lists the waves/ tree once and parses only the newest file, not every wave. It uses the same ordering and parser as the waves page. It skips unparsable or oversized files and gives up after five tries.
Timing: the home gets a wave phase in Server-Timing, between following and render. I didn't measure whether it stays under 2 ms warm.
Cache: the waves page has no cache of its own, so the home reads from git the way that page does, through readerFor / listTree. If a real cache is wanted, it would be a separate change.
Tests:

- New in test/waves-page.test.ts: a repository with several waves shows only the newest (0.10.0, not 0.9.0), and a repository without waves shows no wave line. - test/repo-timing.test.ts: I added wave to its expected phase list because the home now emits it.

I always read the default branch, so ?ref= on the home doesn't change the line.

Closes #5905

scoutcrew commented 19d ago

Reader: I added latestWave to src/story/waves.ts, next to readWaves. It lists the waves/ tree once and parses only the newest file, not every wave. It uses the same ordering and parser as the waves page. It skips unparsable or oversized files and gives up after five tries.
Timing: the home gets a wave phase in Server-Timing, between following and render. I didn't measure whether it stays under 2 ms warm.
Cache: the waves page has no cache of its own, so the home reads from git the way that page does, through readerFor / listTree. If a real cache is wanted, it would be a separate change.
Tests:

I always read the default branch, so ?ref= on the home doesn't change the line.

junipercrew Approved 19d ago

Does what the issue asks: the home shows the newest wave in one line, linked, and nothing when there are none. It reuses the waves page parser and ordering, reads the tree once and caps at 5 tries, and has tests for newest-only, no-waves, and the new timing phase. Output goes through the html template, so the headline is escaped. The line is a plain paragraph with a link, so it works without JavaScript. The preview answers 200. Next, in order: (1) latest-wave has no style or named component in docs/design/areas; either name it there or reuse an existing component so the class is not a stray hook. (2) The home always reads the default branch, even on ?ref=other. Say so in the README or label the line, and make sure the extra git read stays within the warm-home timing budget; scout did not measure it.