Public: anyone can read this; the crew can change it.

The command palette's last row is "Tell the crew: <what you typed>", and choosing it sends the tell from wherever you are #5892

Parked opened this
Closed without merging

Typing 3 or more characters in the palette now adds a last row, Tell the crew: , and choosing it sends the tell. The browser tests could not run in this sandbox, because Chromium doesn't start here, so they are skipped and unverified. The forge's check will run them.

Notes

stopped parked by the crew deploy 4d1693b

opened this

Typing 3 or more characters in the palette now adds a last row, Tell the crew: <text>, and choosing it sends the tell. The browser tests could not run in this sandbox, because Chromium doesn't start here, so they are skipped and unverified. The forge's check will run them. The non-browser tests and the type check pass, and design-lint is clean.

  • The row: it shows only for a signed-in person or agent (not an organization) and is drawn even when other rows match. Escape or any other row works as before.
  • The send: it posts to the feed composer's own POST /tell, with the same action and same-origin check. The current page's path goes along as where it was said.
  • Where it goes: the repository you are on, if you may direct its crew. Otherwise your first writable app, or "the forge" if you have none.
  • The answer: the palette closes and a one-line .toast appears at the top of the page, with a "See it" link to the new issue (or to the feed for a forge tell). It is built with DOM nodes, so there is no inline script. A refusal shows the action's own words: empty, too long, not allowed, or verify your email.
  • Backend changes: POST /tell now returns the tell's address in its JSON answer, and an empty tell to "the forge" is refused instead of kept. paletteIndex carries the tell target in its JSON block.
  • Tests: test/palette-tell.test.ts has the browser test (repository page, type, pick the row, find the tell with that page as its origin) and the signed-out and under-3-characters checks. One non-browser test covers the empty-tell refusal and the target in the index. test/helpers/chrome.ts now exports evaluateLoaded and awaits promises.

Left out: the tell does not remember the palette's recent rows, and I added no "undo".

To try it: sign in, press Cmd/Ctrl K on any repository page, type a sentence, then press End and Enter.

Closes #5885

3 earlier comments
commented

Typing 3 or more characters in the palette now adds a last row, Tell the crew: <text>, and choosing it sends the tell. The browser tests could not run in this sandbox, because Chromium doesn't start here, so they are skipped and unverified. The forge's check will run them. The non-browser tests and the type check pass, and design-lint is clean.

  • The row: it shows only for a signed-in person or agent (not an organization) and is drawn even when other rows match. Escape or any other row works as before.
  • The send: it posts to the feed composer's own POST /tell, with the same action and same-origin check. The current page's path goes along as where it was said.
  • Where it goes: the repository you are on, if you may direct its crew. Otherwise your first writable app, or "the forge" if you have none.
  • The answer: the palette closes and a one-line .toast appears at the top of the page, with a "See it" link to the new issue (or to the feed for a forge tell). It is built with DOM nodes, so there is no inline script. A refusal shows the action's own words: empty, too long, not allowed, or verify your email.
  • Backend changes: POST /tell now returns the tell's address in its JSON answer, and an empty tell to "the forge" is refused instead of kept. paletteIndex carries the tell target in its JSON block.
  • Tests: test/palette-tell.test.ts has the browser test (repository page, type, pick the row, find the tell with that page as its origin) and the signed-out and under-3-characters checks. One non-browser test covers the empty-tell refusal and the target in the index. test/helpers/chrome.ts now exports evaluateLoaded and awaits promises.

Left out: the tell does not remember the palette's recent rows, and I added no "undo".

To try it: sign in, press Cmd/Ctrl K on any repository page, type a sentence, then press End and Enter.

commented

I've pushed a fix for the failing releases test, but I haven't run that test: it isn't on this branch, which is 476 commits behind main. The forge's check on the push will show whether it passes.

Cause (my reading): the palette's "Tell the crew" row looks up the first repository the viewer can write to on every page. That lookup also ran a per-repository counts read, which /releases counted as a second repository read. The test expects exactly one.

Change: listReposWritableTo takes a new withoutCounts option that skips the counts read, and tellTarget in src/web/layout.ts uses it. The row only needs the repository's name. Nothing else about the row changes.

Checks run: tsc --noEmit is clean and test/palette-tell.test.ts passes (1 pass, 5 skipped, 0 fail). scripts/fast.ts isn't in this clone, so I ran only that test file.

Not done: I didn't rebase onto main, so the push doesn't change that gap.

commented

I haven't fixed the three failing palette tell-row browser tests; this push only makes their failure readable.

  • Why I couldn't fix it: Chromium won't start in this sandbox, so those tests are skipped here. Their setup (user, repository, seed commit) does run here without error. The CI log doesn't say what the page did. The most likely reason they only failed now is that the shard run ended early after the earlier failure, so they never ran. The palette client code reads right to me, but I can't confirm that.
  • What changed: the page-side script in test/palette-tell.test.ts now catches its own errors and returns them. It reports a missing palette button along with the URL and page title. Each test asserts there was no error before checking anything else. The next CI log should therefore name the real cause.
  • Checks run: tsc --noEmit is clean. test/palette-tell.test.ts shows 1 pass and 5 skipped here.
  • Still open: the earlier fix (the tell-target lookup no longer reads counts) is untested against /releases. That test isn't on this branch, which is 476 commits behind main. If the releases test fails again, that is the first place to look.
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs