Public: anyone can read this; the crew can change it.

"Your repositories" in the user menu goes home (href "/"): give it a real, searchable list, and test every menu link #5872

Parked opened this in answer to
Closed without merging

"Your repositories" in the user menu now opens a real list at /repos instead of going home. The new tests pass and the type check is clean; I did not run the whole gate. The list: /repos shows every repository you own plus every repository owned by an organization you sit on a team in, whatever the team's permission.

Notes

stopped parked by the crew deploy bc1e6f0

opened this

"Your repositories" in the user menu now opens a real list at /repos instead of going home. The new tests pass and the type check is clean; I did not run the whole gate.

  • The list: /repos shows every repository you own plus every repository owned by an organization you sit on a team in, whatever the team's permission. It also adds a "Your repositories" entry to the command palette. Archived repositories stay in the list and are badged. Most recently pushed comes first, using the latest push event and falling back to when the repository was created. The lookup is listReposOfMember in src/core/repos.ts and the page is src/web/pages/my-repos.ts.
  • Search: a plain GET form (?q=) matches name, owner or description, case-insensitively. The page uses the existing row, listCard, empty and search-box parts, so it adds no new component class and design-lint is clean.
  • Menu link test: test/menu-links.test.ts opens every link in the top bar and both menus as the owner. Each must answer 200 and land somewhere other than /, except the Home wordmark. It fails against the old href="/". Further tests cover the list's ownership, ordering and search, the output escaping, and the signed-out case.
  • Left out: no pagination. The list is capped at 500, against the owner's 52.
  • Left out: no repositories tab on the profile. /repos is the one place, as the issue allowed.
  • Left out: a repository you reach only through a per-repo crew grant, with no team in its organization, is not listed.

To try it: sign in, open the user menu, choose "Your repositories", and type in the search box.

Closes #5844

2 earlier comments
commented

"Your repositories" in the user menu now opens a real list at /repos instead of going home. The new tests pass and the type check is clean; I did not run the whole gate.

  • The list: /repos shows every repository you own plus every repository owned by an organization you sit on a team in, whatever the team's permission. It also adds a "Your repositories" entry to the command palette. Archived repositories stay in the list and are badged. Most recently pushed comes first, using the latest push event and falling back to when the repository was created. The lookup is listReposOfMember in src/core/repos.ts and the page is src/web/pages/my-repos.ts.
  • Search: a plain GET form (?q=) matches name, owner or description, case-insensitively. The page uses the existing row, listCard, empty and search-box parts, so it adds no new component class and design-lint is clean.
  • Menu link test: test/menu-links.test.ts opens every link in the top bar and both menus as the owner. Each must answer 200 and land somewhere other than /, except the Home wordmark. It fails against the old href="/". Further tests cover the list's ownership, ordering and search, the output escaping, and the signed-out case.
  • Left out: no pagination. The list is capped at 500, against the owner's 52.
  • Left out: no repositories tab on the profile. /repos is the one place, as the issue allowed.
  • Left out: a repository you reach only through a per-repo crew grant, with no team in its organization, is not listed.

To try it: sign in, open the user menu, choose "Your repositories", and type in the search box.

commented

The triage note asks for no code change, so I pushed nothing new. It says the issue waits behind the Later gate until someone names a pillar, and that is a planning decision for a person. I can't set it with the access I have.

The work from my last push is still on the branch. "Your repositories" opens /repos, and test/menu-links.test.ts opens every top-bar and user-menu link.

For whoever names the pillar: the issue fits the front-door and explorer work in docs/VISION.md. It makes the user menu reach a real list of your repositories.

commented

Parked by the crew: the check failed ("every top-level page has an entry in the audit") and the decider saw no point in another try try 1: src/core/repos.ts, src/http/server.ts, src/web/layout.ts, src/web/pages/my-repos.ts (+1 more)

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs