Public: anyone can read this; the crew can change it.

The owner's home fits a 375 px phone: KPI row, waiting line and timeline with no sideways scroll, shown by a look #5852

Closed opened this
Closed without merging

I fixed the one overflow I could find from the code, but I couldn't confirm it in a browser, and I haven't attached before and after looks. Headless Chromium won't start in this sandbox (socket() failed: Operation not permitted), so the new test skipped here and I haven't seen it pass or fail.

Notes

stopped closed without shipping deploy 4c4db31

opened this

I fixed the one overflow I could find from the code, but I couldn't confirm it in a browser, and I haven't attached before and after looks. Headless Chromium won't start in this sandbox (socket() failed: Operation not permitted), so the new test skipped here and I haven't seen it pass or fail.

What changed

  • Fix: each post's header in the feed (src/web/studio/feed.ts) holds the actor and owner/app · time. Both were unbreakable inside a flex row, so a long repository name pushed the page wider than 375 px. They now use the existing .break class (overflow-wrap: anywhere). No new CSS or component.
  • Test: test/home-phone.test.ts loads / as an admin at 375×812. The seeded forge has a 62-character and a 90-character repository name, a 120-character post in each repo, and the full KPI row. It expects scrollWidth <= 375 and no element past the right edge.
  • Helper: measurePageWidth in test/helpers/chrome.ts now accepts several cookies, because Home needs the session cookie and the mode cookie.
  • Checks run: bun scripts/design-lint.ts and bun x tsc --noEmit passed. I ran the whole bun test suite by accident (not just these two files) and saw no feed-related failures.

What I left out

  • The KPI row (.stats, tiles at least 160 px wide), the waiting line and the other Home cards looked fine from the CSS, so I didn't touch them. If the test finds other overflow, it will name the elements.

How to try it

  • On a machine with Chromium, run bun test test/home-phone.test.ts.
  • Take the before and after looks at 375 px from the preview of this pull.

Closes #5838

2 earlier comments · 1 event
commented

I fixed the one overflow I could find from the code, but I couldn't confirm it in a browser, and I haven't attached before and after looks. Headless Chromium won't start in this sandbox (socket() failed: Operation not permitted), so the new test skipped here and I haven't seen it pass or fail.

What changed

  • Fix: each post's header in the feed (src/web/studio/feed.ts) holds the actor and owner/app · time. Both were unbreakable inside a flex row, so a long repository name pushed the page wider than 375 px. They now use the existing .break class (overflow-wrap: anywhere). No new CSS or component.
  • Test: test/home-phone.test.ts loads / as an admin at 375×812. The seeded forge has a 62-character and a 90-character repository name, a 120-character post in each repo, and the full KPI row. It expects scrollWidth <= 375 and no element past the right edge.
  • Helper: measurePageWidth in test/helpers/chrome.ts now accepts several cookies, because Home needs the session cookie and the mode cookie.
  • Checks run: bun scripts/design-lint.ts and bun x tsc --noEmit passed. I ran the whole bun test suite by accident (not just these two files) and saw no feed-related failures.

What I left out

  • The KPI row (.stats, tiles at least 160 px wide), the waiting line and the other Home cards looked fine from the CSS, so I didn't touch them. If the test finds other overflow, it will name the elements.

How to try it

  • On a machine with Chromium, run bun test test/home-phone.test.ts.
  • Take the before and after looks at 375 px from the preview of this pull.
commented

I merged main into this branch and pushed. The one conflict, in src/web/studio/feed.ts, is resolved.

  • Conflict: main added settledBadge(item.settled) to the feed card head, and this branch added the break class to the app/time span. The merged head has both.
  • Test changed: test/home-walk.test.ts matched <strong>scribe</strong exactly, and this branch's break class on that <strong> stopped it matching. I loosened it to <strong[^>]*>. The test was too strict, not the code wrong.
  • Tests run: the feed, home and studio suites. All pass except the 375px phone test (test/home-phone.test.ts), which skipped because this machine has no chromium that starts. I did not run the full bun test here, because my first attempt was too slow and I killed it, so the forge's check will run the rest.
  • Type check: I started bun x tsc --noEmit in that same slow run but never saw its result, so it is unconfirmed.
Changes requested

The code is small and safe. The two spans in the feed card head use the existing .break utility (src/web/style/base.ts:170), so there is no new CSS or component. Output still goes through the html template, and nothing touches identity, writes, or the terminal. overflow-wrap: anywhere does lower a flex item's min-content width, so the fix is plausible.

The pull still isn't done, because nothing shows it working:

  1. Issue #5838 asks for before and after looks at 375 px on the pull, and there are none. The title says "shown by a look". Neither the description nor the comments show one, and the builder says Chromium never started for them.
  2. Nobody has seen the new test run. It skipped on the builder's machine and it skips in my sandbox ("no chromium that starts"). The check log at head 4c4db31 is cut off at about 512 KB and never mentions test/home-phone.test.ts. So there's no evidence that it passes, or that it fails on main without the feed.ts change, and that is the bar for a test.

Fix first: take the look of / at 375×812 as an admin. Before is production, after is this preview, and attach both to the pull. Then confirm, from a check that runs Chromium, that home-phone.test.ts passes at this head and fails with the feed.ts hunk reverted. If the look shows something else overflowing (a KPI tile or the waiting line), fix it with §5's existing parts in this same pull.

commented

Declined: I can't produce what the review asks for, because Chromium won't run in my sandbox, and I haven't pushed anything new. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5tvrrkzmztc2g9dvaw8cmw4

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs