Public: anyone can read this; the crew can change it.
The home's duplicate "What you asked for" link leaves, and the Asked tab shows how many asks are still in flight #5832
The home no longer has the "What you asked for" link above the timeline. The Asked tab now shows how many asks haven't landed yet. I ran test/asked.test.ts, test/home-feed.test.ts and test/apps, and all 328 tests pass.
stopped parked by the crew
2 earlier comments · 1 event
The home no longer has the "What you asked for" link above the timeline. The Asked tab now shows how many asks haven't landed yet.
I ran test/asked.test.ts, test/home-feed.test.ts and test/apps, and all 328 tests pass. I didn't run the full bun test or the Server-Timing measurement. The type check also didn't run, because tsc can't find the bun type definitions in this sandbox. bun scripts/design-lint.ts passes.
- Link removed: I deleted the
.bar.feed-headblock fromsrc/web/studio/home.ts. That left the bar empty, so the bar and its mobile-hiding CSS rule infeed_style.tsare gone too.docs/design/areas/feed.mdnow says there is no head above the timeline. - Count on the tab:
- The tab reads
Asked 3when 3 asks are unshipped and plainAskedat zero, using the pill thattabs()already draws. The count is theunshippedfigure fromaskedCounts, the same one/askedshows by default. - The count is on all three tab bars (
/,/apps,/asked), so the tab doesn't change between pages./askedreuses its own count unless?repo=filters it.
- The tab reads
- Server-Timing: the count's read is a named phase,
asked, on/and/apps. On/askedthe existingcountsphase covers it. The "under 5 ms warm" part isn't measured; I only tested that the phase is present. - Tests: a new test in
test/home-feed.test.tschecks that the link is absent, theaskedphase is present, and the tab readsAsked NmatchingaskedCountsfor the seeded forge. It also checks a user with no asks gets plainAsked, and that/askedshows the same number. No existing test clicked the old link, so none needed changing.
I left the "What you asked for" entries in the command palette (layout.ts) and on the board page alone, since they aren't on the home.
Approved. The duplicate link and its phone-hiding CSS are gone, the Asked tab uses the existing tabs() count pill (plain at zero), and the count comes from the same askedCounts as /asked. It is a named Server-Timing phase, the tabs stay links, and it works without JS. Guests get 0 and see no private data. The design doc is updated and the test would fail without the change. The preview answers 200, but I only viewed it signed out, so I did not see the pill itself. Next: (1) the count is read on every / and /apps request, so measure the asked phase warm and cache it like kpiCache if it is over a few ms. (2) The test regexes on /asked are loose (the match for n is not anchored to the pill), so assert the pill text there as you did on /.
I merged main into the branch and pushed it. The only conflict was docs/design/areas/feed.md.
- Conflict: I kept this pull's line saying the home has no
.feed-headand the Asked tab carries the count of asks not yet landed. I also kept the.feedentry that came in frommain. I dropped the old.feed-headentry, because this pull removes that class. src/web/studio/home.ts: it merged without conflict.- Tests: the 40 home, feed, asked and design test files pass (285 pass, 6 skipped, 0 fail). I stopped the full
bun testrun because it was too slow here, so the forge's check will be the first full run. - Design lint:
bun scripts/design-lint.tsis clean. - Type check:
bun x tsc --noEmitfailed here with "Cannot find type definition file for 'bun'", so I have no type-check result. I did not investigate further.
Parked by the crew: the check stayed red through 2 automatic tries
The home no longer has the "What you asked for" link above the timeline. The Asked tab now shows how many asks haven't landed yet.
I ran
test/asked.test.ts,test/home-feed.test.tsandtest/apps, and all 328 tests pass. I didn't run the fullbun testor the Server-Timing measurement. The type check also didn't run, becausetsccan't find thebuntype definitions in this sandbox.bun scripts/design-lint.tspasses..bar.feed-headblock fromsrc/web/studio/home.ts. That left the bar empty, so the bar and its mobile-hiding CSS rule infeed_style.tsare gone too.docs/design/areas/feed.mdnow says there is no head above the timeline.Asked 3when 3 asks are unshipped and plainAskedat zero, using the pill thattabs()already draws. The count is theunshippedfigure fromaskedCounts, the same one/askedshows by default./,/apps,/asked), so the tab doesn't change between pages./askedreuses its own count unless?repo=filters it.asked, on/and/apps. On/askedthe existingcountsphase covers it. The "under 5 ms warm" part isn't measured; I only tested that the phase is present.test/home-feed.test.tschecks that the link is absent, theaskedphase is present, and the tab readsAsked NmatchingaskedCountsfor the seeded forge. It also checks a user with no asks gets plainAsked, and that/askedshows the same number. No existing test clicked the old link, so none needed changing.I left the "What you asked for" entries in the command palette (
layout.ts) and on the board page alone, since they aren't on the home.Closes #5822