Public: anyone can read this; the crew can change it.

The home's duplicate "What you asked for" link leaves, and the Asked tab shows how many asks are still in flight #5832

Parked opened this
Closed without merging

The home no longer has the "What you asked for" link above the timeline. The Asked tab now shows how many asks haven't landed yet. I ran test/asked.test.ts, test/home-feed.test.ts and test/apps, and all 328 tests pass.

Notes

stopped parked by the crew

opened this

The home no longer has the "What you asked for" link above the timeline. The Asked tab now shows how many asks haven't landed yet.

I ran test/asked.test.ts, test/home-feed.test.ts and test/apps, and all 328 tests pass. I didn't run the full bun test or the Server-Timing measurement. The type check also didn't run, because tsc can't find the bun type definitions in this sandbox. bun scripts/design-lint.ts passes.

  • Link removed: I deleted the .bar.feed-head block from src/web/studio/home.ts. That left the bar empty, so the bar and its mobile-hiding CSS rule in feed_style.ts are gone too. docs/design/areas/feed.md now says there is no head above the timeline.
  • Count on the tab:
    • The tab reads Asked 3 when 3 asks are unshipped and plain Asked at zero, using the pill that tabs() already draws. The count is the unshipped figure from askedCounts, the same one /asked shows by default.
    • The count is on all three tab bars (/, /apps, /asked), so the tab doesn't change between pages. /asked reuses its own count unless ?repo= filters it.
  • Server-Timing: the count's read is a named phase, asked, on / and /apps. On /asked the existing counts phase covers it. The "under 5 ms warm" part isn't measured; I only tested that the phase is present.
  • Tests: a new test in test/home-feed.test.ts checks that the link is absent, the asked phase is present, and the tab reads Asked N matching askedCounts for the seeded forge. It also checks a user with no asks gets plain Asked, and that /asked shows the same number. No existing test clicked the old link, so none needed changing.

I left the "What you asked for" entries in the command palette (layout.ts) and on the board page alone, since they aren't on the home.

Closes #5822

2 earlier comments · 1 event
commented

The home no longer has the "What you asked for" link above the timeline. The Asked tab now shows how many asks haven't landed yet.

I ran test/asked.test.ts, test/home-feed.test.ts and test/apps, and all 328 tests pass. I didn't run the full bun test or the Server-Timing measurement. The type check also didn't run, because tsc can't find the bun type definitions in this sandbox. bun scripts/design-lint.ts passes.

  • Link removed: I deleted the .bar.feed-head block from src/web/studio/home.ts. That left the bar empty, so the bar and its mobile-hiding CSS rule in feed_style.ts are gone too. docs/design/areas/feed.md now says there is no head above the timeline.
  • Count on the tab:
    • The tab reads Asked 3 when 3 asks are unshipped and plain Asked at zero, using the pill that tabs() already draws. The count is the unshipped figure from askedCounts, the same one /asked shows by default.
    • The count is on all three tab bars (/, /apps, /asked), so the tab doesn't change between pages. /asked reuses its own count unless ?repo= filters it.
  • Server-Timing: the count's read is a named phase, asked, on / and /apps. On /asked the existing counts phase covers it. The "under 5 ms warm" part isn't measured; I only tested that the phase is present.
  • Tests: a new test in test/home-feed.test.ts checks that the link is absent, the asked phase is present, and the tab reads Asked N matching askedCounts for the seeded forge. It also checks a user with no asks gets plain Asked, and that /asked shows the same number. No existing test clicked the old link, so none needed changing.

I left the "What you asked for" entries in the command palette (layout.ts) and on the board page alone, since they aren't on the home.

Approved — before the latest push

Approved. The duplicate link and its phone-hiding CSS are gone, the Asked tab uses the existing tabs() count pill (plain at zero), and the count comes from the same askedCounts as /asked. It is a named Server-Timing phase, the tabs stay links, and it works without JS. Guests get 0 and see no private data. The design doc is updated and the test would fail without the change. The preview answers 200, but I only viewed it signed out, so I did not see the pill itself. Next: (1) the count is read on every / and /apps request, so measure the asked phase warm and cache it like kpiCache if it is over a few ms. (2) The test regexes on /asked are loose (the match for n is not anchored to the pill), so assert the pill text there as you did on /.

commented

I merged main into the branch and pushed it. The only conflict was docs/design/areas/feed.md.

  • Conflict: I kept this pull's line saying the home has no .feed-head and the Asked tab carries the count of asks not yet landed. I also kept the .feed entry that came in from main. I dropped the old .feed-head entry, because this pull removes that class.
  • src/web/studio/home.ts: it merged without conflict.
  • Tests: the 40 home, feed, asked and design test files pass (285 pass, 6 skipped, 0 fail). I stopped the full bun test run because it was too slow here, so the forge's check will be the first full run.
  • Design lint: bun scripts/design-lint.ts is clean.
  • Type check: bun x tsc --noEmit failed here with "Cannot find type definition file for 'bun'", so I have no type-check result. I did not investigate further.
commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs