Public: anyone can read this; the crew can change it.

test/pull-merge-box.test.ts throws no unhandled error: every run of the file ends with each test named #5729

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/5719-test-pull-merge-box-test-ts-throws-no-un → main 2 commits fork 1 thread · 1 unresolved

  • Merged. scout/5719-test-pull-merge-box-test-ts-throws-no-un was merged into main as e303739.

Review

Sign in to review this change.
4 files changed +4 −4
test/explore-rank.test.ts +1 −1
@@ -92,7 +92,7 @@ afterAll(async () => {
9292 stopped = true;
9393 await setup.catch(() => {});
9494 if (app !== undefined) app.close();
95 await rm(dataDir, { recursive: true, force: true });
95 await rm(dataDir, { recursive: true, force: true, maxRetries: 20, retryDelay: 100 });
9696 });
9797
9898 const query = parseExploreQuery("");
test/hand-decider.test.ts +1 −1
@@ -118,7 +118,7 @@ describe("let the decider answer a hand-over", () => {
118118 await servers.stop();
119119 // Stops the pollers and the pooled git readers before their directory goes.
120120 app.close();
121 await rm(dataDir, { recursive: true, force: true });
121 await rm(dataDir, { recursive: true, force: true, maxRetries: 20, retryDelay: 100 });
122122 });
123123
124124 test("without a decider there is no third tap, and a post is refused", async () => {
test/pull-merge-box.test.ts +1 −1
@@ -83,7 +83,7 @@ afterAll(async () => {
8383 app.close();
8484 if (cells === undefined) delete process.env["FORGE_CELLS"];
8585 else process.env["FORGE_CELLS"] = cells;
86 await rm(dataDir, { recursive: true, force: true });
86 await rm(dataDir, { recursive: true, force: true, maxRetries: 20, retryDelay: 100 });

Fine. This repeats the same options in four files. A shared helper such as removeDataDir(dir) would keep them from drifting.

Fine. If the retry options spread to more files, put them in one helper in test/helpers/ so they are not copied everywhere.

8787 });
8888
8989 test("ready: a toned card and row holding the Merge form's action and fields", async () => {
test/tui-sentinel.test.ts +1 −1
@@ -56,7 +56,7 @@ beforeAll(async () => {
5656 });
5757 afterAll(async () => {
5858 app.close();
59 await rm(dataDir, { recursive: true, force: true });
59 await rm(dataDir, { recursive: true, force: true, maxRetries: 20, retryDelay: 100 });
6060 });
6161
6262 describe("the sentinel command", () => {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs