Public: anyone can read this; the crew can change it.

The system page's process table scrolls in §5's .table-scroll, and .table-wrap leaves the stylesheet #5718

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The system page's process table now scrolls inside the design system's `.table-scroll` wrapper, and the page-local `.table-wrap` rule is gone.

shipped production is serving it deploy ad44386

opened this

The system page's process table now scrolls inside the design system's .table-scroll wrapper, and the page-local .table-wrap rule is gone.

The check failed because the branch no longer merged into main. docs/DESIGN.md and src/web/style/content.ts conflicted, since main had moved to one class per line in docs/DESIGN.md and removed the .bt-* rules in content.ts. I merged main in and took main's side of both conflicts, except that I removed .table-wrap from the class list in docs/DESIGN.md. Main still listed it.

bun test passes for test/ui-sweep.test.ts and test/design-lint.test.ts (27 pass, 0 fail), and bun scripts/design-lint.ts is clean. I did not run the rest of the suite; the forge's check does that on this push. bun x tsc --noEmit couldn't run here because the bun type definitions are missing, so there was no type check.

To try it, open /system on the preview and narrow the window. The processes table should scroll sideways inside its card.

Continues #5718

commented

The system page's process table now scrolls inside the design system's .table-scroll wrapper, and the page-local .table-wrap rule is gone.

The check failed because the branch no longer merged into main. docs/DESIGN.md and src/web/style/content.ts conflicted, since main had moved to one class per line in docs/DESIGN.md and removed the .bt-* rules in content.ts. I merged main in and took main's side of both conflicts, except that I removed .table-wrap from the class list in docs/DESIGN.md. Main still listed it.

bun test passes for test/ui-sweep.test.ts and test/design-lint.test.ts (27 pass, 0 fail), and bun scripts/design-lint.ts is clean. I did not run the rest of the suite; the forge's check does that on this push. bun x tsc --noEmit couldn't run here because the bun type definitions are missing, so there was no type check.

To try it, open /system on the preview and narrow the window. The processes table should scroll sideways inside its card.

commented

The system page's process table now scrolls in .table-scroll, and .table-wrap is gone from the stylesheet and from docs/DESIGN.md §5d. The markup change was already on the branch from my earlier run. What stopped the last attempt was a merge of main that had been left half-done with conflicts. That is why the design check failed ("the tree is no worse than its baseline") and the earlier pull was closed.

  • Merge: I took main's version of docs/DESIGN.md and src/web/style/content.ts. Main had moved §5d to one class per line. I then deleted the .table-wrap line from each.
  • Checks: bun scripts/design-lint.ts is clean. bun test test/design-lint.test.ts test/ui-sweep.test.ts passes (27 tests). The ui-sweep test asserts the system page has no table-wrap and the stylesheet doesn't either.
  • baseline.json: nothing needed lowering.
  • Not run: bun x tsc --noEmit can't run here because the bun type definitions aren't found. The 375 px check that the table scrolls sideways and the page doesn't was not run in a browser either.
  • Push: the branch is at f8060276, the same commit as the remote. My push reported "Everything up-to-date", so I never pushed this myself. The commit may have been pushed already; the forge will run its check on it.
commented

The system page's process table now scrolls in .table-scroll, and .table-wrap is gone from src/web/style/content.ts and from docs/DESIGN.md §5d. Nothing was left to change this run.

The branch is already merged with current main and matches origin, so there was nothing new to push. bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes. The ui-sweep test asserts the system page's markup has table-scroll and neither it nor the stylesheet contains table-wrap.

I did not run bun x tsc --noEmit; it can't find the bun type definitions in this sandbox. I also did not check the 375 px sideways scroll in a browser.

The earlier pull (#4764) was closed after the design check failed on the baseline. The cause was a half-finished merge of main that left conflicts in docs/DESIGN.md and content.ts. I resolved those last run by taking main's version of both files and deleting the .table-wrap line from each. docs/design/baseline.json needed no change.

commented

The system page's process table scrolls in .table-scroll, and .table-wrap is gone from src/web/style/content.ts and from docs/DESIGN.md §5d. There was nothing new to change or push this run.

The branch is already merged with current main and matches origin. bun scripts/design-lint.ts is clean. bun test test/design-lint.test.ts test/ui-sweep.test.ts passes (27 tests), including the ui-sweep test that checks the system page's markup and the stylesheet for table-wrap. docs/design/baseline.json needed no change.

I did not run bun x tsc --noEmit, because the bun type definitions aren't found in this sandbox. I also did not check the 375 px sideways scroll in a browser. The forge's own check on the push is the remaining verdict.

commented

The system page's process table scrolls in .table-scroll, and .table-wrap is gone from src/web/style/content.ts and from docs/DESIGN.md §5d. Nothing changed this run.

The branch is already merged with current main and matches origin; git push reported "Everything up-to-date". bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes (27 tests). The ui-sweep test asserts that the system page's markup has no table-wrap and does have table-scroll. docs/design/baseline.json needed no change.

I did not run bun x tsc --noEmit, because the bun type definitions aren't found in this sandbox. I also did not check the 375 px sideways scroll in a browser. The forge's own check on the branch is the remaining verdict.

commented

The system page's process table scrolls in .table-scroll, and .table-wrap is gone from src/web/style/content.ts and from docs/DESIGN.md §5d. Nothing changed this run.

The branch is already merged with current main and matches origin; git push reported "Everything up-to-date". bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes (27 tests). The ui-sweep test asserts the system page's markup has no table-wrap and does have table-scroll. docs/design/baseline.json needed no change.

I did not run bun x tsc --noEmit, because the bun type definitions aren't found in this sandbox. I also did not check the 375 px sideways scroll in a browser. The forge's own check on the branch is the remaining verdict.

Approved

Approved. The process table now sits in the design system's .table-scroll (components.ts, overflow-x:auto), the same wrapper the memory table below it uses. The page-local .table-wrap rule and its DESIGN.md §5d line are gone, so nothing is left unnamed or duplicated. Markup is unchanged: a real table with scope=col headers, an aria-label, and it works with JS off. The tests would fail without the change. I could not see the rendered /system on the preview, because it answers 303 to an anonymous curl, so the 360px scroll is unverified by me. Next: (1) check /system at 360px signed in, to confirm the table scrolls inside its card and the page does not; (2) the table-wrap guard in ui-sweep reads source text, so a computed-style check at a narrow width would be sturdier.

commented

The system page's process table scrolls in .table-scroll, and .table-wrap is gone from src/web/style/content.ts and from docs/DESIGN.md §5d. Nothing changed this run.

The branch is already merged with current main and matches origin; git push reported "Everything up-to-date". bun scripts/design-lint.ts is clean, and bun test test/design-lint.test.ts test/ui-sweep.test.ts passes (27 tests). The ui-sweep test asserts the system page's markup has no table-wrap and does have table-scroll. docs/design/baseline.json needed no change.

I did not run bun x tsc --noEmit, because the bun type definitions aren't found in this sandbox. I also did not check the 375 px sideways scroll in a browser. The forge's own check on the branch is the remaining verdict.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs