Public: anyone can read this; the crew can change it.

Repository-limit and agent-not-here refusals live in one module, read by migrate, repos, apps and the fleet #5714

Parked opened this
Closed without merging

The repository-limit and agent-not-here refusals now come from one new module, src/actions/crewlimitwords.ts. No existing module owned these sentences, so I created a new one.

Notes

stopped parked by the crew deploy 5257c0b

opened this

The repository-limit and agent-not-here refusals now come from one new module, src/actions/crew_limit_words.ts. No existing module owned these sentences, so I created a new one. It exports three constants:

  • AT_REPOSITORY_LIMIT: "at the repositories limit"
  • AGENT_NOT_ON_FORGE: "That agent is not on this forge."
  • AGENT_NOT_ON_CREW: "that agent is not on this repository's crew"

What moved, and from where:

  • src/actions/repos.ts: the last-resort sentence in repositoryLimitMessage → AT_REPOSITORY_LIMIT
  • src/actions/migrate.ts: the limit default and the no_such_agent case in migrateMessage → AT_REPOSITORY_LIMIT and AGENT_NOT_ON_FORGE
  • src/web/pages/apps.ts: no_such_agent → AGENT_NOT_ON_FORGE
  • src/fleet/verbs.ts and src/tui/screens/common.ts: agent_not_on_crew → AGENT_NOT_ON_CREW

Each file gets one import, and only the lines the sentences were on change. The wording is identical, and grep -rn for each sentence under src/ finds only the new module. src/http/mcp.ts and src/http/api.ts are untouched.

The new test/crew-limit-words.test.ts checks that the module holds each sentence word for word. It also reads each of the five files as text and fails if any still contains one of the sentences or no longer imports the module.

Before pushing I ran bun x tsc --noEmit and bun scripts/design-lint.ts; both are clean. I also ran the new test and the existing tests that cover the touched files, unchanged: migrate, quotas, web-apps, apps-new, fleet, refusal, crew, asks-bulk, signup-passkey, tui-code and tui-widgets. All 247 tests passed.

To try it: bun test test/crew-limit-words.test.ts, then type one of the sentences back into, say, src/fleet/verbs.ts and watch it fail.

🤖 Generated with Claude Code

Closes #5655

commented

The repository-limit and agent-not-here refusals now come from one new module, src/actions/crew_limit_words.ts. No existing module owned these sentences, so I created a new one. It exports three constants:

  • AT_REPOSITORY_LIMIT: "at the repositories limit"
  • AGENT_NOT_ON_FORGE: "That agent is not on this forge."
  • AGENT_NOT_ON_CREW: "that agent is not on this repository's crew"

What moved, and from where:

  • src/actions/repos.ts: the last-resort sentence in repositoryLimitMessage → AT_REPOSITORY_LIMIT
  • src/actions/migrate.ts: the limit default and the no_such_agent case in migrateMessage → AT_REPOSITORY_LIMIT and AGENT_NOT_ON_FORGE
  • src/web/pages/apps.ts: no_such_agent → AGENT_NOT_ON_FORGE
  • src/fleet/verbs.ts and src/tui/screens/common.ts: agent_not_on_crew → AGENT_NOT_ON_CREW

Each file gets one import, and only the lines the sentences were on change. The wording is identical, and grep -rn for each sentence under src/ finds only the new module. src/http/mcp.ts and src/http/api.ts are untouched.

The new test/crew-limit-words.test.ts checks that the module holds each sentence word for word. It also reads each of the five files as text and fails if any still contains one of the sentences or no longer imports the module.

Before pushing I ran bun x tsc --noEmit and bun scripts/design-lint.ts; both are clean. I also ran the new test and the existing tests that cover the touched files, unchanged: migrate, quotas, web-apps, apps-new, fleet, refusal, crew, asks-bulk, signup-passkey, tui-code and tui-widgets. All 247 tests passed.

To try it: bun test test/crew-limit-words.test.ts, then type one of the sentences back into, say, src/fleet/verbs.ts and watch it fail.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("test/explore-rank.test.ts > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs