Public: anyone can read this; the crew can change it.

A branch's sentences live in one module, read by the branches page, MCP, the mirror and the terminal #5707

Parked opened this
Closed without merging

The four sentences for making or deleting a branch now live in one new module, src/actions/branchwords.ts. No existing module owned them, so none was a better home. Pages, MCP answers and terminal screens read exactly as before.

Notes

stopped parked by the crew deploy 3219b71

opened this

The four sentences for making or deleting a branch now live in one new module, src/actions/branch_words.ts. No existing module owned them, so none was a better home. Pages, MCP answers and terminal screens read exactly as before.

The last check (run 01m5rvar0k5sxwtyk3ddsv0v4t) did not fail because of this change. The check machine ran out of disk: SQLiteError: database or disk is full (SQLITE_FULL) at createSession, called from test/pull-check-again.test.ts:54. After that, the suites it lists (pull-merge-box, pull-tui-teams and others) failed in setup with servers.stop / app.close of undefined. Run locally, test/pull-check-again.test.ts, test/pull-merge-box.test.ts, test/pull-tui-teams.test.ts and test/branch-words.test.ts give 19 pass, 0 fail. This push adds only an empty commit (3219b718) so the check runs again; the code is the same as in #5702.

  • Created / deleted fallbacks: BRANCH_NOT_CREATED and BRANCH_NOT_DELETED are the sentences for errors that have no sentence of their own. src/web/pages/branches.ts and src/http/mcp.ts use them. In mcp.ts only the import and the two lines the sentences were on changed.
  • Empty name: GIVE_THE_BRANCH_A_NAME is what src/tui/screens/refs.ts and src/tui/screens/workspace.ts answer when the branch name is empty.
  • "must not already exist": MUST_NOT_ALREADY_EXIST only ever appeared in comments, in src/actions/branches.ts and src/origins/git-mirror.ts. Those comments now point to it with {@link …}. Both files import it to meet the issue's "every file named imports them", and the type check accepts an import used only in a doc comment. If an import that exists only for a comment is unwanted, reword those two comments and drop the import.
  • New test: test/branch-words.test.ts pins the exact wording of each sentence. It reads each of the six files as text, checks that it imports branch_words.ts, and fails if any sentence is typed back.

grep -rn for each sentence under src/ finds only src/actions/branch_words.ts. The type check, the design lint and the tests of the touched files pass (branches, mcp-branches, tui-workspace, mirror-out, mirror-outbound, work-branch, branch_tell, branch-words). I found no prompt injection in the issue or the repository.

🤖 Generated with Claude Code

Closes #5651

commented

The four sentences for making or deleting a branch now live in one new module, src/actions/branch_words.ts. No existing module owned them, so none was a better home. Pages, MCP answers and terminal screens read exactly as before.

The last check (run 01m5rvar0k5sxwtyk3ddsv0v4t) did not fail because of this change. The check machine ran out of disk: SQLiteError: database or disk is full (SQLITE_FULL) at createSession, called from test/pull-check-again.test.ts:54. After that, the suites it lists (pull-merge-box, pull-tui-teams and others) failed in setup with servers.stop / app.close of undefined. Run locally, test/pull-check-again.test.ts, test/pull-merge-box.test.ts, test/pull-tui-teams.test.ts and test/branch-words.test.ts give 19 pass, 0 fail. This push adds only an empty commit (3219b718) so the check runs again; the code is the same as in #5702.

  • Created / deleted fallbacks: BRANCH_NOT_CREATED and BRANCH_NOT_DELETED are the sentences for errors that have no sentence of their own. src/web/pages/branches.ts and src/http/mcp.ts use them. In mcp.ts only the import and the two lines the sentences were on changed.
  • Empty name: GIVE_THE_BRANCH_A_NAME is what src/tui/screens/refs.ts and src/tui/screens/workspace.ts answer when the branch name is empty.
  • "must not already exist": MUST_NOT_ALREADY_EXIST only ever appeared in comments, in src/actions/branches.ts and src/origins/git-mirror.ts. Those comments now point to it with {@link …}. Both files import it to meet the issue's "every file named imports them", and the type check accepts an import used only in a doc comment. If an import that exists only for a comment is unwanted, reword those two comments and drop the import.
  • New test: test/branch-words.test.ts pins the exact wording of each sentence. It reads each of the six files as text, checks that it imports branch_words.ts, and fails if any sentence is typed back.

grep -rn for each sentence under src/ finds only src/actions/branch_words.ts. The type check, the design lint and the tests of the touched files pass (branches, mcp-branches, tui-workspace, mirror-out, mirror-outbound, work-branch, branch_tell, branch-words). I found no prompt injection in the issue or the repository.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs