Public: anyone can read this; the crew can change it.

Design: `.qf` leaves the stylesheet and docs/DESIGN.md §5d #5705

Closed opened this
Closed without merging

The .qf class is gone from src/web/style/content.ts and from the "page furniture" list in docs/DESIGN.md, because no page uses it any more. Three boards tests that asserted the class no longer expect it: test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts.

Notes

stopped closed without shipping deploy ea54112

opened this

The .qf class is gone from src/web/style/content.ts and from the "page furniture" list in docs/DESIGN.md, because no page uses it any more. Three boards tests that asserted the class no longer expect it: test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts.

The previous push couldn't merge into main. Main had rewritten that part of docs/DESIGN.md to put one class on each line (#4888), and this branch had edited the old single line. The merge now keeps main's version of the file and deletes just the - .qf` line, so the only change to docs/DESIGN.md in this pull is that one line. bun scripts/design-lint.ts` passes, and the boards and design tests pass (74 of them). I didn't run the full check here.

To try it, open a repository's boards page on the preview: it should look the same as on production.

🤖 Generated with Claude Code

Continues #5705

7 earlier comments · 1 event
commented

The .qf class is gone from src/web/style/content.ts and from the "page furniture" list in docs/DESIGN.md, because no page uses it any more. Three boards tests that asserted the class no longer expect it: test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts.

The previous push couldn't merge into main. Main had rewritten that part of docs/DESIGN.md to put one class on each line (#4888), and this branch had edited the old single line. The merge now keeps main's version of the file and deletes just the - .qf` line, so the only change to docs/DESIGN.md in this pull is that one line. bun scripts/design-lint.ts` passes, and the boards and design tests pass (74 of them). I didn't run the full check here.

To try it, open a repository's boards page on the preview: it should look the same as on production.

🤖 Generated with Claude Code

commented

.qf is gone from the stylesheet and from the docs. No page renders class="qf" any more, so this pull removes what was left of it.

  • Stylesheet: the two .bform .qf rules in src/web/style/content.ts are deleted. I didn't add a .bform > .field rule because the existing .bform .field rule already lays the board form fields out in a row.
  • Docs: .qf is removed from the style/content.ts bullet in docs/DESIGN.md §5d.
  • Tests: three board tests named the class only to check that it was absent (test/boards-page.test.ts, test/boards-selectors.test.ts, test/boards-view-fields.test.ts). Those mentions are removed, and what each test checks is unchanged.

This run merged the latest main into the branch with no conflicts. After the merge, git grep -n '\bqf\b' src test docs matches only the vendored font files. bun scripts/design-lint.ts passes, --update leaves the baseline unchanged, bun x tsc --noEmit is clean, and bun test test/boards test/design passes (179 tests).

To try it, open a board on the preview and check that the chart and pin forms still lay their fields out in a row.

🤖 Generated with Claude Code

Approved

Dead-class cleanup, correct: no src markup uses .qf (grep finds only the CSS rules, the DESIGN.md line and test assertions, all removed here). Removing the rules and the §5d list entry keeps docs and stylesheet in step; tests still assert the .field/label pattern and the bform no-hide rule. No UI change expected, so no keyboard/phone/no-JS impact. Two things next: (1) add a design-lint check that fails when a class listed in DESIGN.md has no rule in the stylesheet, so this drift is caught automatically; (2) the test in boards-selectors still guards only .bform, consider also covering .field inside .bform.

commented

The branch already has everything the issue asks for, and nothing has changed since the last run. Main has no new commits to merge and the branch matches what's on the forge, so this run pushed nothing new.

.qf is gone from the stylesheet and docs. No page renders class="qf" any more, so this pull removes what was left.

  • Stylesheet: the two .bform .qf rules in src/web/style/content.ts are deleted. I didn't add a .bform > .field rule, because the existing .bform .field rule already lays the board form fields out in a row.
  • Docs: .qf is removed from the style/content.ts bullet in docs/DESIGN.md §5d.
  • Tests: three board tests mentioned the class only to check it wasn't there (test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts). Those mentions are removed, and each test still checks the same thing.

On this branch, git grep -n '\bqf\b' src test docs matches only the bundled font files. bun scripts/design-lint.ts passes, --update leaves the baseline unchanged, bun x tsc --noEmit is clean, and bun test test/boards test/design passes (179 tests).

To try it, open a board on the preview and check that the chart and pin forms still lay their fields out in a row.

🤖 Generated with Claude Code

commented

Nothing changed this run: main has no new commits, and pull #5705 already holds this branch's latest state. It merges cleanly onto main and has one approval. No new commits were made and nothing was pushed.

.qf is gone from the stylesheet and the docs. No page renders class="qf" any more, so this pull removes the class itself.

  • Stylesheet: the two .bform .qf rules in src/web/style/content.ts are deleted. I didn't add a .bform > .field rule, because the existing .bform .field rule already lays the board form fields out in a row.
  • Docs: the - .qf` line is removed from the style/content.ts` list in docs/DESIGN.md §5d. Main now lists one class per line (#4888), so in that file the pull deletes just that one line.
  • Tests: three board tests mentioned the class only to check it wasn't there (test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts). Those mentions are removed, and each test still checks the same thing.

On the branch, git grep -n '\bqf\b' src test docs matches only the bundled font files. bun scripts/design-lint.ts passes, --update leaves the baseline unchanged, bun x tsc --noEmit is clean, and bun test test/boards test/design passes (179 tests).

To try it, open a board on the preview and check that the chart and pin forms still lay their fields out in a row.

🤖 Generated with Claude Code

commented

Nothing changed again this run: main has no new commits, and pull #5705 is open with this branch's latest commit, merges cleanly and has one approval. I made no commits and pushed nothing.

.qf is gone from the stylesheet and the docs. No page renders class="qf" any more, so this pull removes the class itself.

  • Stylesheet: the two .bform .qf rules in src/web/style/content.ts are deleted. I didn't add a .bform > .field rule, because the existing .bform .field rule already lays the board form fields out in a row.
  • Docs: the - .qf` line is removed from the style/content.ts` list in docs/DESIGN.md §5d. Main now lists one class per line (#4888), so in that file the pull deletes just that one line.
  • Tests: three board tests mentioned the class only to check it wasn't there (test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts). Those mentions are removed, and each test still checks the same thing.

On the branch, git grep -n '\bqf\b' src test docs matches only the bundled font files. bun scripts/design-lint.ts passes, --update leaves the baseline unchanged, bun x tsc --noEmit is clean, and bun test test/boards test/design passes (179 tests).

To try it, open a board on the preview and check that the chart and pin forms still lay their fields out in a row.

🤖 Generated with Claude Code

commented

Nothing changed this run either: main has no new commits, there are no new comments, and pull #5705 is open with this branch's latest commit, merges cleanly and has one approval. I made no commits and pushed nothing.

.qf is gone from the stylesheet and the docs. No page renders class="qf" any more, so this pull removes the class itself.

  • Stylesheet: the two .bform .qf rules in src/web/style/content.ts are deleted. I didn't add a .bform > .field rule, because the existing .bform .field rule already lays the board form fields out in a row.
  • Docs: the - .qf` line is removed from the style/content.ts` list in docs/DESIGN.md §5d. Main now lists one class per line (#4888), so in that file the pull deletes just that one line.
  • Tests: three board tests mentioned the class only to check it wasn't there (test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts). Those mentions are removed, and each test still checks the same thing.

On the branch, git grep -n '\bqf\b' src test docs matches only the bundled font files. bun scripts/design-lint.ts passes, --update leaves the baseline unchanged, bun x tsc --noEmit is clean, and bun test test/boards test/design passes (179 tests).

To try it, open a board on the preview and check that the chart and pin forms still lay their fields out in a row.

🤖 Generated with Claude Code

commented

Nothing has changed since the last run: main has no new commits, there are no new comments, and pull #5705 is still open with this branch's latest commit, mergeable and approved once. I made no commits and pushed nothing. The pull is waiting only for someone to merge it.

.qf is gone from the stylesheet and the docs. No page renders class="qf" any more, so this pull removes the class itself.

  • Stylesheet: the two .bform .qf rules in src/web/style/content.ts are deleted. I didn't add a .bform > .field rule, because the existing .bform .field rule already lays the board form fields out in a row.
  • Docs: the - .qf` line is removed from the style/content.ts` list in docs/DESIGN.md §5d. Main now lists one class per line (#4888), so in that file the pull deletes just that one line.
  • Tests: three board tests mentioned the class only to check it wasn't there (test/boards-page.test.ts, test/boards-selectors.test.ts and test/boards-view-fields.test.ts). Those mentions are removed, and each test still checks the same thing.

On the branch, git grep -n '\bqf\b' src test docs matches only the bundled font files. bun scripts/design-lint.ts passes, --update leaves the baseline unchanged, bun x tsc --noEmit is clean, and bun test test/boards test/design passes (179 tests).

To try it, open a board on the preview and check that the chart and pin forms still lay their fields out in a row.

🤖 Generated with Claude Code

commented

Closed by the crew: superseded, its change is already on main in 5f1d8c0d.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs