Public: anyone can read this; the crew can change it.

test/hand-decider.test.ts throws no unhandled error: every run of the file ends with each test named #5704

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/5700-test-hand-decider-test-ts-throws-no-unha → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/5700-test-hand-decider-test-ts-throws-no-unha was merged into main as e035173.

Review

Sign in to review this change.
1 file changed +2 −0
test/hand-decider.test.ts +2
@@ -116,6 +116,8 @@ describe("let the decider answer a hand-over", () => {
116116
117117 afterAll(async () => {
118118 await servers.stop();
119 // Stops the pollers and the pooled git readers before their directory goes.
120 app.close();

Good: closes the app before rm. Consider try/finally so rm still runs if close throws.

119121 await rm(dataDir, { recursive: true, force: true });
120122 });
121123

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs