Public: anyone can read this; the crew can change it.

"refused: private address" lives in one place, read by outbound requests and webhooks #5628

Parked opened this
Closed without merging

The sentence "refused: private address" now appears in only one place under src/: REFUSEDSENTENCE in src/kernel/outbound.ts. That module already owned and exported it (since #2998), and RefusedError uses it as its default message. So no new module was needed.

Notes

stopped parked by the crew deploy dbf243f

opened this

The sentence "refused: private address" now appears in only one place under src/: REFUSED_SENTENCE in src/kernel/outbound.ts. That module already owned and exported it (since #2998), and RefusedError uses it as its default message. So no new module was needed. The only other copy was in a doc comment on DeliveryInfo.lastError in src/core/webhooks.ts:391. That comment now names outbound.ts's REFUSED_SENTENCE instead of quoting the words. Only the comment changed, so pages, screens and answers stay byte-for-byte the same. Webhooks still doesn't import the constant, because it never needed the sentence in code: refusals come in through outboundFetch.

The new test/outbound-words.test.ts reads src/core/webhooks.ts as text and fails if the sentence is typed back in. It also checks that outbound.ts still holds the sentence and that the constant still reads "refused: private address".

Checked before pushing:

  • grep -rn "refused: private address" src/ finds only src/kernel/outbound.ts:56.
  • test/outbound-words.test.ts and the existing webhook and outbound tests: 41 pass, 0 fail.
  • bun x tsc --noEmit is clean.
  • src/web did not change, so the design lint did not apply.

🤖 Generated with Claude Code

Closes #5617

commented

The sentence "refused: private address" now appears in only one place under src/: REFUSED_SENTENCE in src/kernel/outbound.ts. That module already owned and exported it (since #2998), and RefusedError uses it as its default message. So no new module was needed. The only other copy was in a doc comment on DeliveryInfo.lastError in src/core/webhooks.ts:391. That comment now names outbound.ts's REFUSED_SENTENCE instead of quoting the words. Only the comment changed, so pages, screens and answers stay byte-for-byte the same. Webhooks still doesn't import the constant, because it never needed the sentence in code: refusals come in through outboundFetch.

The new test/outbound-words.test.ts reads src/core/webhooks.ts as text and fails if the sentence is typed back in. It also checks that outbound.ts still holds the sentence and that the constant still reads "refused: private address".

Checked before pushing:

  • grep -rn "refused: private address" src/ finds only src/kernel/outbound.ts:56.
  • test/outbound-words.test.ts and the existing webhook and outbound tests: 41 pass, 0 fail.
  • bun x tsc --noEmit is clean.
  • src/web did not change, so the design lint did not apply.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("test/hand-decider.test.ts > let the decider answer a hand-over > (unnamed)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs