Public: anyone can read this; the crew can change it.

A note from the app's own origin is a visitor's unless it carries the forge panel's one-use proof #5604

Parked opened this
Closed without merging

I changed no code this round. The earlier red came from an unrelated merge-queue test, so I pushed an empty commit to re-run the check. What failed: "the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)" in test/merge-queue.test.ts.

Notes

stopped parked by the crew deploy dba259f

opened this

I changed no code this round. The earlier red came from an unrelated merge-queue test, so I pushed an empty commit to re-run the check.

What failed: "the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)" in test/merge-queue.test.ts. That test is about a timing deadline and doesn't touch the feedback door, the panel or the proxy. The three files that changed in the last round are src/apps/proof.ts (new), src/apps/feedback.ts and src/apps/toolbar.ts, plus the proxy and tests.

What I checked: the branch is already on top of origin/main, with nothing new on main. test/merge-queue.test.ts passed 3 runs out of 3 here (16 tests each). My earlier runs of test/apps-feedback.test.ts, test/toolbar-actions.test.ts, test/apps-crew-pill.test.ts and bun x tsc --noEmit were all green. I did not run those again after the rebase attempt, which changed nothing.

What the change does:

  • Page load: a signed-in person's page load puts a one-use token in the panel's script tag. The token is bound to the grant cookie and the host, and the panel strips it from the tag on load. That page answers cache-control: private, no-store.
  • Spending the token: POST /__forge/note and GET /__forge/notes spend it. With a valid token the note is @name and the list is theirs. With no token, or one that is reused, foreign-grant or foreign-host, the note is visitor-…, the list is the visitor's and admin is false.
  • Next token: every answer to a valid proof carries the next token in x-forge-proof.

What I left out:

  • Restart: tokens are held in memory, so a restart makes open panels visitors until the page reloads.
  • Unproven requests: a sealed preview or private app answers 404 to an unproven notes request.
  • Not exercised end to end: I never loaded a real proxied page. The tests call issueProof and pageLoad directly, so the proxy's issuing step and the panel script's use of the token are not exercised.

To try it: load a signed-in app page, open the panel and send a note, which should come back as @you. A curl with the grant cookie but no x-forge-proof should come back as visitor-….

If the merge-queue test fails again on this push, it needs its own issue. It is a timing test that failed under load, and it failed in the check before I touched the branch again.

Closes #5395

commented

I changed no code this round. The earlier red came from an unrelated merge-queue test, so I pushed an empty commit to re-run the check.

What failed: "the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)" in test/merge-queue.test.ts. That test is about a timing deadline and doesn't touch the feedback door, the panel or the proxy. The three files that changed in the last round are src/apps/proof.ts (new), src/apps/feedback.ts and src/apps/toolbar.ts, plus the proxy and tests.

What I checked: the branch is already on top of origin/main, with nothing new on main. test/merge-queue.test.ts passed 3 runs out of 3 here (16 tests each). My earlier runs of test/apps-feedback.test.ts, test/toolbar-actions.test.ts, test/apps-crew-pill.test.ts and bun x tsc --noEmit were all green. I did not run those again after the rebase attempt, which changed nothing.

What the change does:

  • Page load: a signed-in person's page load puts a one-use token in the panel's script tag. The token is bound to the grant cookie and the host, and the panel strips it from the tag on load. That page answers cache-control: private, no-store.
  • Spending the token: POST /__forge/note and GET /__forge/notes spend it. With a valid token the note is @name and the list is theirs. With no token, or one that is reused, foreign-grant or foreign-host, the note is visitor-…, the list is the visitor's and admin is false.
  • Next token: every answer to a valid proof carries the next token in x-forge-proof.

What I left out:

  • Restart: tokens are held in memory, so a restart makes open panels visitors until the page reloads.
  • Unproven requests: a sealed preview or private app answers 404 to an unproven notes request.
  • Not exercised end to end: I never loaded a real proxied page. The tests call issueProof and pageLoad directly, so the proxy's issuing step and the panel script's use of the token are not exercised.

To try it: load a signed-in app page, open the panel and send a note, which should come back as @you. A curl with the grant cookie but no x-forge-proof should come back as visitor-….

If the merge-queue test fails again on this push, it needs its own issue. It is a timing test that failed under load, and it failed in the check before I touched the branch again.

commented

Parked by the crew: the check failed ("the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs