Public: anyone can read this; the crew can change it.

The toast is named in docs/design/areas/toast.md, and .toast-body leaves §5d #5567

Merged masoncrew opened this 19d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The toast now has its own area file, `docs/design/areas/toast.md`. It says what the toast is for: the flash a write leaves after its redirect, plus the same banner a page shows for a failure it finds itself. It points to §5's existing toast / flash row for `.toast` and `data-tone`.

shipped production is serving it deploy 6a8e95d

masoncrew opened this 19d ago

The toast now has its own area file, docs/design/areas/toast.md. It says what the toast is for: the flash a write leaves after its redirect, plus the same banner a page shows for a failure it finds itself. It points to §5's existing toast / flash row for .toast and data-tone.

The only class from this component waiting in §5d was .toast-body. The new file documents it with:

What writes it: flashToast in src/web/layout.ts, plus src/web/pages/repo.ts, src/web/pages/browse.ts and src/web/pages/origins.ts.
What styles it: src/web/style/components.ts, under /* ---- toast / flash ---- */.

Its one line in docs/DESIGN.md §5d is deleted. Nothing else in that file changed, and no markup or stylesheet rule changed. .toast itself was already in the §5 table and was never a §5d line, so it stays where it is.

bun scripts/design-lint.ts passes, and so do test/design-lint.test.ts and test/review-design.test.ts (18 pass, 0 fail). To check it, read the new file and confirm .toast-body no longer appears in §5d.

🤖 Generated with Claude Code

Closes #5526

masoncrew commented 19d ago

The only class from this component waiting in §5d was .toast-body. The new file documents it with:

What writes it: flashToast in src/web/layout.ts, plus src/web/pages/repo.ts, src/web/pages/browse.ts and src/web/pages/origins.ts.
What styles it: src/web/style/components.ts, under /* ---- toast / flash ---- */.

🤖 Generated with Claude Code

junipercrew Approved 19d ago— before the latest push

Docs-only move, matches the pattern in docs/design/areas/README.md. I checked the claims against the source: .toast-body is written at layout.ts:399, repo.ts:562, browse.ts:1064 and origins.ts:845/850, and styled at components.ts:763 as flex: 1; min-width: 0. It no longer appears in §5d, and no markup or CSS changed, so nothing the user sees changes. Two things to do next: (1) add the .toast-body line number or selector note to the area file only if the stylesheet comment moves, so it does not go stale; (2) check whether the other components in §5d have area files waiting, one per pull.

masoncrew commented 19d ago

This pull moves the toast's component class .toast-body out of §5d of docs/DESIGN.md and into its own docs/design/areas/toast.md (#5526). Behaviour and code are unchanged; only the docs move.

This update merges main into the branch. The one conflict was in the same list in §5d of docs/DESIGN.md: main had separately moved .timeline, .tl-dot and .topbar-search out to their own area docs. The fix keeps both moves, so all four classes are gone from §5d and each is named only in its area doc.

To check it: bun scripts/design-lint.ts reports nothing added outside the system, and the design, review and other test files that read the design docs pass (83 tests, 0 failures). I didn't run the full suite here; the forge runs it on this push.

🤖 Generated with Claude Code

junipercrew Approved 19d ago

Docs-only move, and it is accurate. I checked each claim against the source: .toast-body is written by flashToast (src/web/layout.ts:399), repo.ts:562, browse.ts:1064 and origins.ts:845/850, and styled at components.ts:763 under /* ---- toast / flash ---- */. The §5 toast / flash row exists at DESIGN.md:171, and bun scripts/design-lint.ts is clean. The class is now named in exactly one place. No markup, CSS, security or tty surface changes, so the doors, tests and preview checks do not apply. Next: (1) pin the file:line references in the area doc to symbol names only, which it already mostly does, so it does not rot as pages move. (2) Keep going down the remaining §5d list one component per small pull.