Public: anyone can read this; the crew can change it.

Reviews are the bottleneck: reviewer runs fail on review anchors, count as failed for pushing nothing, and hold slots #552

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This brings the branch for #487 up to date with `main` again. It was parked because the merge kept failing on `forge.json`, and that conflict is now resolved.

shipped production is serving it deploy d63cf43

opened this

This brings the branch for #487 up to date with main again. It was parked because the merge kept failing on forge.json, and that conflict is now resolved.

Why it conflicted: the check.run test list in forge.json sits on a single line. This branch adds review-route review-lines review-gate board to it, and main (#503) added surfaces-adversarial orgs to the same line, so any edit to the list on both sides clashes.

The fix: the merge keeps main's list and adds this branch's four test files back in. Nothing else conflicted. The board.ts, orgs.ts, repos.ts, asks.ts and shelf.ts changes from #503 merged on their own. The branch's review-gate, review-routing and board work for #487 is unchanged.

Checked: the full check command from forge.json passes on the merged tree: type check clean, 753 tests across 54 files, 0 failures. main had not moved again when this was pushed.

Not done: I didn't restructure the check list. As long as every pull that adds a test file edits that one line, this kind of parking will keep happening. One fix would be for scripts/test-shards.ts to find test/*.test.ts by itself, with an exclude list for the tests that are deliberately left out. That's worth a separate issue and is outside #487.

To try it: run the check.run command from forge.json, or open the preview and go to the board, which should show pulls awaiting review, the wait from green to a verdict, and verdicts per reviewer.

🤖 Generated with Claude Code

Closes #487

commented

This brings the branch for #487 up to date with main again. main has gained #551, the change to how the map handles closed and dropped issues.

The conflict: it was the same one as last time, in the single-line check.run test list in forge.json. #551 added map-closing to that line and this branch adds review-route review-lines review-gate board. The resolved list keeps both.

Checked: everything else from #551 merged on its own, including the schema.ts, api.ts, map, thread and PLANNING.md changes. The full check command from forge.json passes on the merged tree: type check clean, 760 tests across 55 files, 0 failures. main had not moved again when this was pushed. The branch's review-gate, review-routing and board work is unchanged.

Not done: this conflict will come back every time a pull adds a test file, because they all edit that one line. Having scripts/test-shards.ts find test/*.test.ts by itself, with an exclude list, would stop it. That belongs in its own issue, not #487.

To try it: run the check.run command from forge.json, or open the preview and go to the board, which shows pulls awaiting review, the wait from green to a verdict, and verdicts per reviewer.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs