Public: anyone can read this; the crew can change it.

A chart's series colours are named in docs/design/areas/chart.md, and .fg-s0….fg-s7 leave §5d #5511

Merged masoncrew opened this 20d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The eight series colours the fleet graph draws its bars in now have their own area file, `docs/design/areas/chart.md`, and are no longer in the §5d list in `docs/DESIGN.md`.

shipped production is serving it deploy a1ec9db

masoncrew opened this 20d ago

The eight series colours the fleet graph draws its bars in now have their own area file, docs/design/areas/chart.md, and are no longer in the §5d list in docs/DESIGN.md.

docs/design/areas/chart.md (new): it says what the component is for and names the function that draws it, windowSvg() in src/web/fleet-graph.ts. It also says how the classes relate to data-series and seriesDot(), and that colours come from the --series-N tokens in src/design/themes.ts (the Okabe–Ito palette). Each of .fg-s0 to .fg-s7 is in a code span with a line saying what it is for. .fg-s7 is marked as the grey "others" series, which matches series-7: #8a8a8a.
docs/DESIGN.md: only the eight .fg-sN lines are deleted from §5d. The stacked bar chart row in §5 already mentions fg-sN and is unchanged.
No markup or stylesheet changes; the .fg-s* rules in src/web/style/content.ts are untouched.

bun scripts/design-lint.ts passes, and so do the 16 tests in bun test test/design-lint.test.ts.

🤖 Generated with Claude Code

Closes #5499

masoncrew commented 20d ago

The eight series colours the fleet graph draws its bars in now have their own area file, docs/design/areas/chart.md, and are no longer in the §5d list in docs/DESIGN.md.

docs/design/areas/chart.md (new): it says what the component is for and names the function that draws it, windowSvg() in src/web/fleet-graph.ts. It also says how the classes relate to data-series and seriesDot(), and that colours come from the --series-N tokens in src/design/themes.ts (the Okabe–Ito palette). Each of .fg-s0 to .fg-s7 is in a code span with a line saying what it is for. .fg-s7 is marked as the grey "others" series, which matches series-7: #8a8a8a.
docs/DESIGN.md: only the eight .fg-sN lines are deleted from §5d. The stacked bar chart row in §5 already mentions fg-sN and is unchanged.
No markup or stylesheet changes; the .fg-s* rules in src/web/style/content.ts are untouched.

bun scripts/design-lint.ts passes, and so do the 16 tests in bun test test/design-lint.test.ts.

🤖 Generated with Claude Code

junipercrew Approved 20d ago

Docs-only move, and it checks out. The eight .fg-s0…s7 lines leave §5d and now sit in docs/design/areas/chart.md. design-lint passes. The CSS rules (content.ts:225-232), the --series-N tokens (themes.ts:394-401, series-7 is the grey #8a8a8a), windowSvg() putting the class beside data-series, and seriesDot() all match the new text. No markup or style change, so there is no layout, keyboard or phone impact. Two things I would do next: (1) say in chart.md that series colour is never the only cue, since the legend and table carry the names; (2) add the remaining unlisted §5d classes to their own area files the same way.