Public: anyone can read this; the crew can change it.

The diff view is a component in docs/design/areas/diff.md, and its classes leave §5d #5505

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The diff a pull and a commit show is now documented as one component in its own area file. Its ten page-local classes leave §5d of `docs/DESIGN.md`. This pull only changes documentation: no markup, stylesheet or code changes.

shipped production is serving it deploy 749c831

opened this

The diff a pull and a commit show is now documented as one component in its own area file. Its ten page-local classes leave §5d of docs/DESIGN.md. This pull only changes documentation: no markup, stylesheet or code changes.

  • docs/design/areas/diff.md (new): names the component and says where it is drawn (renderDiff in src/web/diff-view.ts) and styled (src/web/style/content.ts). It explains how the .diff wrapper holds a summary card and one §5 diff file per file. Each class gets a code span and one line on what it is for, taken from the markup and CSS: .diff-summary, .diff-head, .diff-path, .diff-stat, .diff-body, .diff-table, .diff-note, .diff-stub, .dn-comment, .nonl.
  • docs/DESIGN.md: deletes exactly those ten lines from the "diff viewer" list in §5d, and nothing else.

I left the line kinds and gutters (.add, .del, .dh, .diff, .dl, .dn, .wd) in §5d because the issue doesn't list them, and .add/.del are also used outside the diff (the toolbar's .change-line). The new file says they stay in §5d.

To check it: bun scripts/design-lint.ts passes, and so does bun test test/design-lint.test.ts (16 pass). Since nothing else changed, every diff page should render as before.

🤖 Generated with Claude Code

Closes #5493

commented

The diff a pull and a commit show is now documented as one component in its own area file. Its ten page-local classes leave §5d of docs/DESIGN.md. This pull only changes documentation: no markup, stylesheet or code changes.

  • docs/design/areas/diff.md (new): names the component and says where it is drawn (renderDiff in src/web/diff-view.ts) and styled (src/web/style/content.ts). It explains how the .diff wrapper holds a summary card and one §5 diff file per file. Each class gets a code span and one line on what it is for, taken from the markup and CSS: .diff-summary, .diff-head, .diff-path, .diff-stat, .diff-body, .diff-table, .diff-note, .diff-stub, .dn-comment, .nonl.
  • docs/DESIGN.md: deletes exactly those ten lines from the "diff viewer" list in §5d, and nothing else.

I left the line kinds and gutters (.add, .del, .dh, .diff, .dl, .dn, .wd) in §5d because the issue doesn't list them, and .add/.del are also used outside the diff (the toolbar's .change-line). The new file says they stay in §5d.

To check it: bun scripts/design-lint.ts passes, and so does bun test test/design-lint.test.ts (16 pass). Since nothing else changed, every diff page should render as before.

🤖 Generated with Claude Code

Approved

Documentation only, and it matches #5493 exactly. docs/DESIGN.md loses just the ten listed lines from §5d. The line kinds and gutters stay, one class per line. The new docs/design/areas/diff.md names each of the ten classes in a code span. I checked its descriptions against src/web/style/content.ts and src/web/diff-view.ts: sticky head, the 420px container wrap, 12.5px mono table, .diff-stub as a .diff-note, .dn-comment links, the ↵ .nonl mark. They are accurate. With the change applied, bun scripts/design-lint.ts passes and bun test test/design-lint.test.ts passes 16 of 16. No code, markup or CSS changes, so security, the terminal and tests are unaffected. The preview answers 200. Approved.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs