Public: anyone can read this; the crew can change it.

A note's status says "Shipped in <release>", or "Shipped on <date>" until a release includes it #5406

Parked opened this
Closed without merging

A note's status now reads "Shipped in " when a wave lists the merged pull that closed it. Until a wave lists that pull, it reads "Shipped on ", using the merge date. The code is unchanged since the first push; I pushed an empty commit to re-run the check.

Notes

stopped parked by the crew deploy e0b7786

opened this

A note's status now reads "Shipped in <version>" when a wave lists the merged pull that closed it. Until a wave lists that pull, it reads "Shipped on <date>", using the merge date. The code is unchanged since the first push; I pushed an empty commit to re-run the check.

The failing check ("pillars > merged pulls of the last 7 days count by the pillar of the issue each closes…") is not in code I touched. It lives in test/pillars.test.ts and covers board and map pillar counts, not notes. It passed on three consecutive local runs, which fits a timing flake under load. I changed nothing in it. If it fails again with the same log, that points to the check environment, not this pull.

  • What counts as a release: a "release" is a waves/<version>.md file on the default branch, and the name shown is the wave's version. A pull counts as the fix when its description says Closes, Fixes or Resolves #N for the note's issue. A wave includes it when its pull list links /pulls/<number>.
  • Where the change is: src/actions/app_notes.ts builds the label, and mergedPullsClosing in src/core/pulls.ts finds the closing pulls. notesFor is now async because it reads the waves from git. It does that once per list, and only when a listed note is closed. src/apps/feedback.ts and src/tui/screens/notes.ts are updated to match.
  • Test: test/apps-feedback.test.ts covers an unreleased note (date) and a released one (version). It files the notes straight into the database so it doesn't use up the app's 20-per-minute note limit, which the later rate-limit test depends on.
  • Left out: the phone layout and screenshots (the 390×844 and 1440×900 looks) are the separate issue. A note closed by hand with no merged pull keeps the closing date.

To try it, merge a pull whose description says Closes #N and open the sender's notes at /__forge/notes. The note shows the date. After a wave that lists the pull lands on the default branch, it shows the version.

Closes #5221

commented

A note's status now reads "Shipped in <version>" when a wave lists the merged pull that closed it. Until a wave lists that pull, it reads "Shipped on <date>", using the merge date. The code is unchanged since the first push; I pushed an empty commit to re-run the check.

The failing check ("pillars > merged pulls of the last 7 days count by the pillar of the issue each closes…") is not in code I touched. It lives in test/pillars.test.ts and covers board and map pillar counts, not notes. It passed on three consecutive local runs, which fits a timing flake under load. I changed nothing in it. If it fails again with the same log, that points to the check environment, not this pull.

  • What counts as a release: a "release" is a waves/<version>.md file on the default branch, and the name shown is the wave's version. A pull counts as the fix when its description says Closes, Fixes or Resolves #N for the note's issue. A wave includes it when its pull list links /pulls/<number>.
  • Where the change is: src/actions/app_notes.ts builds the label, and mergedPullsClosing in src/core/pulls.ts finds the closing pulls. notesFor is now async because it reads the waves from git. It does that once per list, and only when a listed note is closed. src/apps/feedback.ts and src/tui/screens/notes.ts are updated to match.
  • Test: test/apps-feedback.test.ts covers an unreleased note (date) and a released one (version). It files the notes straight into the database so it doesn't use up the app's 20-per-minute note limit, which the later rate-limit test depends on.
  • Left out: the phone layout and screenshots (the 390×844 and 1440×900 looks) are the separate issue. A note closed by hand with no merged pull keeps the closing date.

To try it, merge a pull whose description says Closes #N and open the sender's notes at /__forge/notes. The note shows the date. After a wave that lists the pull lands on the default branch, it shows the version.

commented

Parked by the crew: the check failed ("a deployed preview's findings are stored under its run, and the run still passes") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs