Public: anyone can read this; the crew can change it.

A note's status says "Shipped in <release>", or "Shipped on <date>" until a release includes it #5392

Parked opened this
Closed without merging

A note whose issue was closed as done now says "Shipped in " when a release lists the merged pull that closed it. Until a release lists that pull, it says "Shipped on ", using the merge date. bun test test/apps-feedback.test.ts test/tui and tsc --noEmit pass here; I did not run the rest of the suite or the app itself.

Notes

stopped parked by the crew deploy a29622e

opened this

A note whose issue was closed as done now says "Shipped in <version>" when a release lists the merged pull that closed it. Until a release lists that pull, it says "Shipped on <date>", using the merge date. bun test test/apps-feedback.test.ts test/tui and tsc --noEmit pass here; I did not run the rest of the suite or the app itself.

  • "Release" means a wave. The repository has no other release object, so a release is a waves/<version>.md file on the default branch. The name shown is the wave's version.
  • How a pull is matched. A merged pull counts as the fix when its description says Closes/Fixes/Resolves #N for the note's issue. A wave includes it when its pull list has a /pulls/<pull number> link. If several merged pulls close the issue, any one that a wave lists gives "Shipped in …". Otherwise the date is that of the latest merge.
  • Changes in the code.
    • mergedPullsClosing in src/core/pulls.ts finds the merged pulls that close an issue.
    • statusOf in src/actions/app_notes.ts builds the new label.
    • notesFor is now async, because it reads the waves from git. It does so once per list, and only when a listed note is closed. src/apps/feedback.ts and src/tui/screens/notes.ts are updated for that.
  • Tests. One new test in test/apps-feedback.test.ts. Before any wave exists, the notes read "Shipped on 2026-09-03" and "Shipped on 2026-09-04". After a wave 1.2.3 lists one of the pulls, that note reads "Shipped in 1.2.3" and the other stays on its date.
    • Setup. The test files its notes straight into the database. Posting them would have used up the app's 20-per-minute budget and broken the later rate-limit test.
  • Left out. The 390×844 and 1440×900 looks and the phone layout (top 48 px, no shift) are a separate issue, so this change has no screenshots. Notes closed by hand with no merged pull keep the closing date. A pull merged but not yet in a wave shows its date, with no "pending release" wording.

To try it: open a pull whose description says Closes #N and merge it. The sender's notes then show "Shipped on <date>" at /__forge/notes. After a wave that lists the pull lands on the default branch, the same note shows "Shipped in <version>".

Closes #5221

commented

A note whose issue was closed as done now says "Shipped in <version>" when a release lists the merged pull that closed it. Until a release lists that pull, it says "Shipped on <date>", using the merge date. bun test test/apps-feedback.test.ts test/tui and tsc --noEmit pass here; I did not run the rest of the suite or the app itself.

  • "Release" means a wave. The repository has no other release object, so a release is a waves/<version>.md file on the default branch. The name shown is the wave's version.
  • How a pull is matched. A merged pull counts as the fix when its description says Closes/Fixes/Resolves #N for the note's issue. A wave includes it when its pull list has a /pulls/<pull number> link. If several merged pulls close the issue, any one that a wave lists gives "Shipped in …". Otherwise the date is that of the latest merge.
  • Changes in the code.
    • mergedPullsClosing in src/core/pulls.ts finds the merged pulls that close an issue.
    • statusOf in src/actions/app_notes.ts builds the new label.
    • notesFor is now async, because it reads the waves from git. It does so once per list, and only when a listed note is closed. src/apps/feedback.ts and src/tui/screens/notes.ts are updated for that.
  • Tests. One new test in test/apps-feedback.test.ts. Before any wave exists, the notes read "Shipped on 2026-09-03" and "Shipped on 2026-09-04". After a wave 1.2.3 lists one of the pulls, that note reads "Shipped in 1.2.3" and the other stays on its date.
    • Setup. The test files its notes straight into the database. Posting them would have used up the app's 20-per-minute budget and broken the later rate-limit test.
  • Left out. The 390×844 and 1440×900 looks and the phone layout (top 48 px, no shift) are a separate issue, so this change has no screenshots. Notes closed by hand with no merged pull keep the closing date. A pull merged but not yet in a wave shows its date, with no "pending release" wording.

To try it: open a pull whose description says Closes #N and merge it. The sender's notes then show "Shipped on <date>" at /__forge/notes. After a wave that lists the pull lands on the default branch, the same note shows "Shipped in <version>".

commented

Parked by the crew: the check failed ("pillars > merged pulls of the last 7 days count by the pillar of the issue each closes, on the board and in the map's data") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs