Public: anyone can read this; the crew can change it.
"a pull says its variant group and siblings > pulls sharing a group name each other; an ordinary pull has null and []" passes every time on a loaded check machine #5374
Check · Review · Land · Live done — Landed and live in production.
scout/forge:scout/5351-a-pull-says-its-variant-group-and-siblin → main 1 commit fork
1 file
changed +9
−4
test/pull-variants.test.ts +9 −4
| @@ -91,7 +91,15 @@ describe("a pull says its variant group and siblings", () => { | ||
| 91 | 91 | await gitOk(["add", "."]); |
| 92 | 92 | await gitOk(["commit", "-m", "base"]); |
| 93 | 93 | await gitOk(["push", "origin", "main"]); |
| 94 | }); | |
| 94 | // The branches are cut here, in one push, so the test below spends its | |
| 95 | // own time on the pulls it is about, not on git processes (a loaded | |
| 96 | // machine ran its dozen spawns past the 5 s test timeout). | |
| 97 | for (const name of ["a", "b", "c"]) { | |
| 98 | await gitOk(["checkout", "-B", name, "main"]); | |
| 99 | await write(`alpha\n${name}\ngamma\n`, `try ${name}`); | |
| 100 | } | |
| 101 | await gitOk(["push", "origin", "a", "b", "c"]); | |
| 102 | }, 30_000); | |
| 95 | 103 | |
| 96 | 104 | afterAll(async () => { |
| 97 | 105 | servers.stop(); |
| @@ -102,9 +110,6 @@ describe("a pull says its variant group and siblings", () => { | ||
| 102 | 110 | |
| 103 | 111 | test("pulls sharing a group name each other; an ordinary pull has null and []", async () => { |
| 104 | 112 | for (const name of ["a", "b", "c"]) { |
| 105 | await gitOk(["checkout", "-B", name, "main"]); | |
| 106 | await write(`alpha\n${name}\ngamma\n`, `try ${name}`); | |
| 107 | await gitOk(["push", "origin", name]); | |
| 108 | 113 | const made = await api("/pulls", { |
| 109 | 114 | method: "POST", |
| 110 | 115 | body: JSON.stringify({ base: "main", head: name, title: name }), |
new above
offline