Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:36a5qcqa3a was degraded 59 minutes today: trevato/forge: "test/og-route.test.ts > og cards > (unnamed)" failed on 3 pulls in the last hour — the lane's red, not … #5360

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/5336-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/5336-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 42f0f07.

Review

Sign in to review this change.
1 file changed +3 −2
test/og-route.test.ts +3 −2
@@ -13,6 +13,7 @@ import { createUser, getUserByName } from "../src/core/users.ts";
1313 import { serve, type Servers } from "../src/http/server.ts";
1414
1515 // Setup creates repos on disk; a loaded check machine must not turn that into a failure.
16 // Hooks take their own timeout, so beforeAll and afterAll name theirs too.

The comment states the premise as fact. If hooks turn out to honour setDefaultTimeout, this line is wrong. Soften it to say hooks may take their own timeout.

1617 setDefaultTimeout(30_000);
1718
1819 describe("og cards", () => {
@@ -101,12 +102,12 @@ describe("og cards", () => {
101102 runId = run("shown");
102103 privateRunId = run("hidden");
103104 quietRunId = run("quiet");
104 });
105 }, 60_000);
105106
106107 afterAll(async () => {
107108 await servers.stop();
108109 await rm(dataDir, { recursive: true, force: true });
109 });
110 }, 30_000);
110111
111112 const get = (path: string, headers: Record<string, string> = {}) =>
112113 fetch(base + path, { headers });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs