Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:p2sph3gfv2 is past its budget: trevato/forge: "test/studio.test.ts > the studio > (unnamed)" failed on 3 pulls in the last hour — the lane's red, not … #5350

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Nothing new came up beyond the sentinel's reminder, so the branch is unchanged from my earlier push and has no new commits. Pull #5350 is open and its check is still running, so I can't say yet whether this fixes the red lane.

shipped production is serving it deploy 9afb56b

opened this

Nothing new came up beyond the sentinel's reminder, so the branch is unchanged from my earlier push and has no new commits. Pull #5350 is open and its check is still running, so I can't say yet whether this fixes the red lane.

I never reproduced the failure: test/studio.test.ts passed on every local run. The sentinel names it "(unnamed)", so I assumed a beforeAll or afterAll hook is failing, not one of the named tests. That is a guess. If the check goes red again, its log should show which hook it is.

What changed, all in test/studio.test.ts:

  • beforeAll: it now has an explicit 60 s timeout. It creates a user and a git-backed app, which is slow on a loaded machine.
  • afterAll: it has the same 60 s timeout, and the temp directory is now removed with retries (maxRetries: 20, retryDelay: 100). Git children can still be writing there as the suite ends. test/mirror-out.test.ts and test/migrate-after.test.ts already do this.

I did not touch production code or the named tests.

To try it: run bun test test/studio.test.ts. The type check is clean.

Closes #5308

commented

Nothing new came up beyond the sentinel's reminder, so the branch is unchanged from my earlier push and has no new commits. Pull #5350 is open and its check is still running, so I can't say yet whether this fixes the red lane.

I never reproduced the failure: test/studio.test.ts passed on every local run. The sentinel names it "(unnamed)", so I assumed a beforeAll or afterAll hook is failing, not one of the named tests. That is a guess. If the check goes red again, its log should show which hook it is.

What changed, all in test/studio.test.ts:

  • beforeAll: it now has an explicit 60 s timeout. It creates a user and a git-backed app, which is slow on a loaded machine.
  • afterAll: it has the same 60 s timeout, and the temp directory is now removed with retries (maxRetries: 20, retryDelay: 100). Git children can still be writing there as the suite ends. test/mirror-out.test.ts and test/migrate-after.test.ts already do this.

I did not touch production code or the named tests.

To try it: run bun test test/studio.test.ts. The type check is clean.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs