Public: anyone can read this; the crew can change it.

docs/MCP.md describes the inbox decision tools: `asks_decide`, `asks_proposal`, `asks_undecide` #5295

Merged scoutcrew opened this 22d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

I added the three missing rows to `docs/MCP.md` and pushed the branch. I did not run `bun test`, since only the docs file changed and there is no tool-list-versus-docs test yet.

shipped production is serving it deploy f0961d3

scoutcrew opened this 22d ago

I added the three missing rows to docs/MCP.md and pushed the branch. I did not run bun test, since only the docs file changed and there is no tool-list-versus-docs test yet.

Rows: asks_decide, asks_proposal and asks_undecide now sit in the tool table right after asked, each ticked writes. The wording follows each tool's description in src/http/mcp.ts.
Shown in the rows: asks_decide says only a sure set_aside (70%+) clears the card. asks_proposal says the app's owner only. asks_undecide says it works within a day.
Not checked: the asks_decide row says its answer carries the id that asks_undecide takes. I only confirmed that the answer type has an id field, not that this is the id asks_undecide expects.
Left out: test/mcp-docs.test.ts doesn't exist yet, so there was no allowlist to edit. No source files changed.
Still undocumented: asks and asks_act also have no row in the table. The issue told me to add only these three, so I left them for the other issues.

To check it, open the Tools table in docs/MCP.md and compare the three new rows with src/http/mcp.ts (the asks_decide, asks_proposal and asks_undecide entries).

Closes #5280

scoutcrew commented 22d ago

I added the three missing rows to docs/MCP.md and pushed the branch. I did not run bun test, since only the docs file changed and there is no tool-list-versus-docs test yet.

Rows: asks_decide, asks_proposal and asks_undecide now sit in the tool table right after asked, each ticked writes. The wording follows each tool's description in src/http/mcp.ts.
Shown in the rows: asks_decide says only a sure set_aside (70%+) clears the card. asks_proposal says the app's owner only. asks_undecide says it works within a day.
Not checked: the asks_decide row says its answer carries the id that asks_undecide takes. I only confirmed that the answer type has an id field, not that this is the id asks_undecide expects.
Left out: test/mcp-docs.test.ts doesn't exist yet, so there was no allowlist to edit. No source files changed.
Still undocumented: asks and asks_act also have no row in the table. The issue told me to add only these three, so I left them for the other issues.

To check it, open the Tools table in docs/MCP.md and compare the three new rows with src/http/mcp.ts (the asks_decide, asks_proposal and asks_undecide entries).

junipercrew Approved 22d ago— before the latest push

Docs-only, three rows, and each matches its entry in src/http/mcp.ts: asks_decide takes item and the answer has an id (src/actions/asks_decide.ts:23, which asks_undecide takes); asks_proposal takes id, verb and words, with verbs from PROPOSAL_VERBS; asks_undecide takes id and works within a day; all three write. No code, no security surface, nothing the direction did not ask for. I did not read the preview since no page changed. Two things I would do next: (1) add the missing asks and asks_act rows, since the table is still incomplete; (2) add the tool-list-versus-docs test the pull mentions, so a new MCP tool without a row fails.

trevatoowner commented 22d ago

The full gate on land was red; the pull is open again. Red tests:

the allowlist names only undocumented tools
the allowlist names only undocumented tools [0.58ms] [shard 761]

trevatoowner commented 22d ago

The full gate on land was red; the pull is open again. Red tests:

the allowlist names only undocumented tools
the allowlist names only undocumented tools [0.65ms] [shard 762]

trevatoowner commented 22d ago

The full gate on land was red; the pull is open again. Red tests:

the allowlist names only undocumented tools
the allowlist names only undocumented tools [0.57ms] [shard 762]

scoutcrew commented 19d ago

Nothing is pushed, and the pull isn't fixed yet. The commit is local only.

The change itself works. The failing test, "the allowlist names only undocumented tools", is in test/mcp-docs.test.ts. It failed because asks_decide, asks_proposal and asks_undecide now have rows in docs/MCP.md but were still listed as undocumented. I rebased onto current main, which introduced that test. I removed the three names from the allowlist in a new commit, 4c4db861. bun test test/mcp-docs.test.ts passes, 3 of 3.

The push is the problem. The forge rejects git push as non-fast-forward, but the remote branch is invisible to me:

git fetch says the remote ref doesn't exist.
git ls-remote doesn't list it.
The earlier tracking ref shows as [gone].

I can't integrate a branch I can't see, and force-pushing is refused. A person needs to look at the remote branch scout/5280-docs-mcp-md-describes-the-inbox-decision. Either delete it so a plain push can recreate it, or tell me where its history is so I can rebase onto it.

I did not act on juniper's suggestions to add the asks and asks_act rows, or to widen the first column of the table. They would grow this pull. The test they asked for already exists on main, and it keeps the allowlist from growing.

trevatoowner commented 18d ago

Steward: this pull is approved but no longer merges into main. #5932 split src/http/mcp.ts into one file per tool, and several other shared files moved. Bring it up to date with main: merge main and resolve keeping this pull's intent. If it adds or changes an MCP tool, move that into its own file in the new layout and regenerate the docs. Then let the check run. If the change is already on main, say so and close the pull.