The `.bt-*` rules leave the stylesheet: no page renders them

masoncrew opened this 22d ago

I removed the eight unused .bt-* classes from the old btop-style system view: their 16 rules are gone from src/web/style/content.ts, and their 8 lines are gone from the page-furniture list in docs/DESIGN.md §5d.

Search. Before the change, a search of the whole repository for bt- found matches in only three places:

docs/DESIGN.md:481-488            (the class list)
src/web/style/content.ts:232-250  (the rules themselves)
test/system-btop.test.ts:104,107  (an existing check that the /system panels write no bt-* class)

Nothing in src/, including pages, studio, client.ts, src/web/pages/system.ts and src/web/system-live.ts, writes a bt- class. The /system panels are already drawn with §5's .row, <meter>, .card and .table. After the change, grep -rn "bt-" src docs finds nothing.

Test. A new test in test/system-btop.test.ts checks that the stylesheet content no longer contains .bt- or any of the eight class names. No existing test changed.

Checks. The type check and bun scripts/design-lint.ts both pass. test/system-btop.test.ts, every test that reads docs/DESIGN.md, test/web.test.ts and all test/system.test.ts pass (174 tests, 0 failures).

Not done. I took no before/after screenshots of /system, though the issue asks for them. The page sits behind a login, and I didn't drive a signed-in browser from the sandbox. Since no markup carried these classes, removing their rules can't change how the page renders. To confirm by eye, open /system on this pull's preview and compare it with production.

🤖 Generated with Claude Code

Closes #5250

masoncrew commented 22d ago

I removed the eight unused .bt-* classes from the old btop-style system view: their 16 rules are gone from src/web/style/content.ts, and their 8 lines are gone from the page-furniture list in docs/DESIGN.md §5d.

Search. Before the change, a search of the whole repository for bt- found matches in only three places:

docs/DESIGN.md:481-488            (the class list)
src/web/style/content.ts:232-250  (the rules themselves)
test/system-btop.test.ts:104,107  (an existing check that the /system panels write no bt-* class)

Nothing in src/, including pages, studio, client.ts, src/web/pages/system.ts and src/web/system-live.ts, writes a bt- class. The /system panels are already drawn with §5's .row, <meter>, .card and .table. After the change, grep -rn "bt-" src docs finds nothing.

Test. A new test in test/system-btop.test.ts checks that the stylesheet content no longer contains .bt- or any of the eight class names. No existing test changed.

Checks. The type check and bun scripts/design-lint.ts both pass. test/system-btop.test.ts, every test that reads docs/DESIGN.md, test/web.test.ts and all test/system.test.ts pass (174 tests, 0 failures).

Not done. I took no before/after screenshots of /system, though the issue asks for them. The page sits behind a login, and I didn't drive a signed-in browser from the sandbox. Since no markup carried these classes, removing their rules can't change how the page renders. To confirm by eye, open /system on this pull's preview and compare it with production.

🤖 Generated with Claude Code

junipercrew Approved 22d ago

Dead-CSS removal only. No file in src/ outside the stylesheet writes a bt- class, and the preview answers 200 on /. DESIGN.md §5d matches the stylesheet, and the new test guards against the rules coming back. No security, keyboard or JS-off impact. I did not compare /system by eye because it is behind a login; since no markup used the classes, nothing should change. Two things next: (1) the new test and the existing one at test/system-btop.test.ts:104 now overlap, so fold them into one when you next touch that file; (2) take the before/after /system screenshots on mobile when someone is signed in.

The `.bt-*` rules leave the stylesheet: no page renders them #5269

Keyboard shortcuts