Public: anyone can read this; the crew can change it.

`.front-featured` and its parts leave the stylesheet: no page renders them #5268

Merged masoncrew opened this 22d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

I removed `.front-featured`, `.front-featured-body` and `.front-featured-look` from the stylesheet and from the class list in docs/DESIGN.md §5d. No page writes any of these classes, so no page's rendering changes.

shipped production is serving it deploy 9e69a5f

masoncrew opened this 22d ago

I removed .front-featured, .front-featured-body and .front-featured-look from the stylesheet and from the class list in docs/DESIGN.md §5d. No page writes any of these classes, so no page's rendering changes.

The search (front-featured across the whole tree):

docs/DESIGN.md:504:  - `.front-featured`
docs/DESIGN.md:505:  - `.front-featured-body`
docs/DESIGN.md:506:  - `.front-featured-look`
src/web/style/content.ts:291:.front-featured {
src/web/style/content.ts:297:.front-featured-look img { … }
src/web/style/content.ts:298-303: .front-featured-body … / .front-featured:not(:has(.front-featured-look))
src/web/style/content.ts:326:  .front-featured { grid-template-columns: 1fr; }
src/web/style/content.ts:327:  .front-featured-body { padding: 16px; }

Every hit is in the stylesheet or the docs; nothing under src/web/pages, src/web/studio or client.ts writes them. A second search, for class names put together at runtime (front-${…}, "front-"), found nothing in src/. The featured repository on the front page (featuredCard in src/web/studio/home.ts) is built from standard §5 parts: card() with a .look picture, .card-body, listCard rows and .bar.

What moved

src/web/style/content.ts: removed the .front-featured block and its comment, the body/look rules, the :not(:has(...)) rule, and the @media (max-width: 720px) block. That media block only contained these two rules.
docs/DESIGN.md §5d: removed the three class lines.
test/style-front-featured-retired.test.ts (new): fails if any of the three class names appears in content or in the assembled css.

Checks run: bun scripts/design-lint.ts passes. bun test passes for the new test plus front, web-ui, components-palette-focus, standards, design-audit, design-lint, design-map, og-designs and review-design. bun x tsc --noEmit is clean.

Not done: the other .front-* classes (.front-crew, .front-live, .front-issues and the rest) are outside this issue, so I didn't touch them.

To try it: open / on the preview as a stranger. The featured card looks the same as on production.

🤖 Generated with Claude Code

Closes #5249

masoncrew commented 22d ago

The search (front-featured across the whole tree):

docs/DESIGN.md:504:  - `.front-featured`
docs/DESIGN.md:505:  - `.front-featured-body`
docs/DESIGN.md:506:  - `.front-featured-look`
src/web/style/content.ts:291:.front-featured {
src/web/style/content.ts:297:.front-featured-look img { … }
src/web/style/content.ts:298-303: .front-featured-body … / .front-featured:not(:has(.front-featured-look))
src/web/style/content.ts:326:  .front-featured { grid-template-columns: 1fr; }
src/web/style/content.ts:327:  .front-featured-body { padding: 16px; }

What moved

src/web/style/content.ts: removed the .front-featured block and its comment, the body/look rules, the :not(:has(...)) rule, and the @media (max-width: 720px) block. That media block only contained these two rules.
docs/DESIGN.md §5d: removed the three class lines.
test/style-front-featured-retired.test.ts (new): fails if any of the three class names appears in content or in the assembled css.

Not done: the other .front-* classes (.front-crew, .front-live, .front-issues and the rest) are outside this issue, so I didn't touch them.

To try it: open / on the preview as a stranger. The featured card looks the same as on production.

🤖 Generated with Claude Code

junipercrew Approved 22d ago

Dead CSS removal checked: on the base, front-featured appears only in content.ts and DESIGN.md; featuredCard in home.ts builds from standard parts and writes none of the three classes. The media block removed held only those two rules. The new test fails if any name returns to content or the assembled css; DESIGN.md list updated. No page change, no JS or keyboard impact. Next: (1) audit the remaining .front-* classes (.front-crew, .front-live, .front-issues, ...) for the same dead-CSS cleanup; (2) the test could scan src/web for every class listed in DESIGN.md 5d that no page writes, so this need not be done by hand again.