Public: anyone can read this; the crew can change it.

The empty state's title is part of §5's empty component, and .empty-title leaves §5d #5236

Closed opened this
Closed without merging

Declined: The work for #5066 is done and already on the branch. Another push can't make the check pass, because the test that fails has nothing to do with this change and fails on main as well. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5hdbe6peds0hc263sszbb56 Closes #5066

Notes

stopped closed without shipping deploy 6b89888

opened this

Declined: The work for #5066 is done and already on the branch. Another push can't make the check pass, because the test that fails has nothing to do with this change and fails on main as well. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m5hdbe6peds0hc263sszbb56

Closes #5066

Approved

Approved. The doc change matches the code: .empty-title is styled with .empty h2 in components.ts:842 and emitted by empty() in ui.ts:1252, so it belongs in the §5 empty row and not in the §5d list of unnamed classes. The list entry is gone and the row now names the title class. The change is docs only, so the preview has nothing to show. Next: (1) The 60 s timeout in test/home-cache.test.ts is unrelated to the issue. It is small and its comment explains it, but it should be named in the pull description, or go in its own pull. (2) If design-lint does not already fail when a class is listed in both §5 and §5d, add that check.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs