Public: anyone can read this; the crew can change it.

"GET /signin names its phases and answers within its budget" passes every time on a loaded check machine #5225

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/5197-get-signin-names-its-phases-and-answers → main 1 commit fork

  • Merged. scout/5197-get-signin-names-its-phases-and-answers was merged into main as 7561a8d.

Review

Sign in to review this change.
1 file changed +15 −9
test/signin-timing.test.ts +15 −9
@@ -33,13 +33,19 @@ const PAGES: [string, string[]][] = [
3333 for (const [path, names] of PAGES)
3434 test(`GET ${path} names its phases and answers within its budget`, async () => {
3535 const against = await baselineMs(servers.url);
36 await fetch(`${servers.url}${path}`); // warm
37 const res = await fetch(`${servers.url}${path}`);
38 await res.text();
39 expect(res.status).toBe(200);
40 const parts = (res.headers.get("server-timing") ?? "").split(", ");
41 for (const name of ["app", ...names])
42 expect(parts.find((p) => p.startsWith(`${name};`))).toMatch(/^[a-z]+;dur=\d+\.\d$/);
43 const app = parts.find((p) => p.startsWith("app;"))!;
44 expectBudget(Number(app.slice("app;dur=".length)), { ms: 10, against });
36 await (await fetch(`${servers.url}${path}`)).text(); // warm
37 // A loaded machine stalls the event loop mid-request and inflates any one
38 // sample; the fastest of a few is what the handler itself costs.
39 let best = Infinity;
40 for (let i = 0; i < 7; i++) {
41 const res = await fetch(`${servers.url}${path}`);
42 await res.text();
43 expect(res.status).toBe(200);
44 const parts = (res.headers.get("server-timing") ?? "").split(", ");
45 for (const name of ["app", ...names])
46 expect(parts.find((p) => p.startsWith(`${name};`))).toMatch(/^[a-z]+;dur=\d+\.\d$/);
47 const app = parts.find((p) => p.startsWith("app;"))!;
48 best = Math.min(best, Number(app.slice("app;dur=".length)));
49 }
50 expectBudget(best, { ms: 10, against });
4551 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs