Public: anyone can read this; the crew can change it.

A studio list with nothing in it blames a filter nobody set #521

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The Told, Changes and Runs lists no longer blame a filter nobody set. My two new tests pass. Most of the other studio tests fail in this sandbox, so I couldn't confirm the rest of the suite. `bun run check` was not run.

shipped production is serving it deploy bbd5a0b

opened this

The Told, Changes and Runs lists no longer blame a filter nobody set. My two new tests pass. Most of the other studio tests fail in this sandbox, so I couldn't confirm the rest of the suite. bun run check was not run.

What changed (src/web/studio/lists.ts, test/studio.test.ts)

  • With no filter set and no rows, each list says what to do next, in one line:

- Told: "Nothing open. Tell the crew what you want and it shows up here." - Changes: "Nothing open. A change is the crew's proposed edit to your app; the crew opens them as it works." - Runs: "Nothing open. A run is one go the crew takes at a job; each one shows up here."

  • With a filter set and no rows, the note names the filter:

- Told: "Nothing told is shipped yet." - Changes: "No change is look yet." - Runs: "No run is stopped yet."

  • The empty card keeps its title, icon and shape.
  • The wording comes from one small helper, emptyNote, used by all three lists.

Tests

  • New describe "the studio's empty lists".
  • It covers a repository with nothing in it, with no filter wording on any of the three pages.
  • It also covers a repository whose rows a filter excludes, with each filter named.
  • The full test/studio.test.ts and test/studio-words.test.ts runs showed 23 failures and 22 errors. The ones I looked at were git_init_failed in setup, and I didn't compare against a baseline run. studio-words.test.ts fails on its own too, and I didn't look into why.

Left out

  • The no-filter line says "Nothing open", not "you haven't started". The default view only reads open rows, so a repository whose rows are all shipped lands on the same line. That is true, and it avoids a query for closed rows.
  • I didn't touch the filter bar or header that #175 changes.

To try: open a brand-new app's /issues, /pulls and /runs in the studio, then add ?word=shipped to see the filter named.

Closes #273

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs