Public: anyone can read this; the crew can change it.

A form error on the account page is §5's field error, not .error-note #5193

Parked opened this
Closed without merging

Both account-page form errors now sit in their input's .field as §5's .error, and account.ts no longer writes error-note. I made this change in an earlier run (19ae0d42) and added nothing new this time. It is already on the branch, so there was nothing to push.

Notes

stopped parked by the crew deploy 4337b8a

opened this

Both account-page form errors now sit in their input's .field as §5's .error, and account.ts no longer writes error-note. I made this change in an earlier run (19ae0d42) and added nothing new this time. It is already on the branch, so there was nothing to push.

  • Change: the Notify URL error (near line 115) now shows beside the URL field. The SSH key error (near line 824) now shows beside the Public key field. The two <p class="error-note"> lines are gone.
  • Tests: test/notify.test.ts and test/keys.test.ts now check that a bad submission has no error-note and that the message sits inside <div class="field" data-invalid> as <span class="error">.
  • Password change: the issue's "bad password change" test is not there. I checked only the password page's source, which has no error-note, and I did not look for an error on that form. The two forms I did test were Notify URL and SSH key.
  • Earlier failure: test/perimeter-mediums.test.ts failed on pull #5076. It passes here on this branch, which is current with main. It never touches the account page, so I think the failure was a flake, but I can't tell from here.
  • Checks run: tsc --noEmit is clean and bun scripts/design-lint.ts passes. The notify and perimeter tests pass. The SSH-key assertions are skipped in this sandbox because it has no keygen, so only the forge's check will run them. I left the .error-note rule and §5d alone, as the issue says.

Closes #5067

commented

Both account-page form errors now sit in their input's .field as §5's .error, and account.ts no longer writes error-note. I made this change in an earlier run (19ae0d42) and added nothing new this time. It is already on the branch, so there was nothing to push.

  • Change: the Notify URL error (near line 115) now shows beside the URL field. The SSH key error (near line 824) now shows beside the Public key field. The two <p class="error-note"> lines are gone.
  • Tests: test/notify.test.ts and test/keys.test.ts now check that a bad submission has no error-note and that the message sits inside <div class="field" data-invalid> as <span class="error">.
  • Password change: the issue's "bad password change" test is not there. I checked only the password page's source, which has no error-note, and I did not look for an error on that form. The two forms I did test were Notify URL and SSH key.
  • Earlier failure: test/perimeter-mediums.test.ts failed on pull #5076. It passes here on this branch, which is current with main. It never touches the account page, so I think the failure was a flake, but I can't tell from here.
  • Checks run: tsc --noEmit is clean and bun scripts/design-lint.ts passes. The notify and perimeter tests pass. The SSH-key assertions are skipped in this sandbox because it has no keygen, so only the forge's check will run them. I left the .error-note rule and §5d alone, as the issue says.
commented

Parked by the crew: the check failed ("refused while any admin has a working credential > the stranded admin itself, or another admin, has sign-in with the parent") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs