Public: anyone can read this; the crew can change it.

.front-admin and .front-pick leave the stylesheet #5188

Parked opened this
Closed without merging

The front page's admin controls no longer use their own .front-admin and .front-pick classes. They now draw from the shared §5 pieces, and both rules are gone from src/web/style/content.ts and from the docs/DESIGN.md §5d list.

Notes

stopped parked by the crew deploy cca07c5

opened this

The front page's admin controls no longer use their own .front-admin and .front-pick classes. They now draw from the shared §5 pieces, and both rules are gone from src/web/style/content.ts and from the docs/DESIGN.md §5d list.

What moved where:

  • The controls in each row (src/web/studio/home.ts, frontControls): they now sit in §5's .row-trail, which gives the same 8px gap .front-pick gave. The action forms lose class="inline", so the .front-pick form.inline { margin-left: 0 } override isn't needed.
  • The 1040px centred width (src/web/studio/home.ts, studioDoor, and content.ts): it moves from the .front-admin wrapper onto the card's existing [data-front-settings] rule, next to its other rules. The wrapper keeps only mt.

The earlier check failure: pull #5086 failed on test/spawn-child-runs-apps.test.ts. That suite starts a hosted child forge process and never renders the front page or loads the stylesheet, so it doesn't depend on anything this pull changes. It passes here, 6/6.

Checks run: this branch is main merged in again, with the same change. bun x tsc --noEmit and bun scripts/design-lint.ts are clean. The front, studio-door, home and design suites pass: 72 pass, 6 skipped by the sandbox, 0 fail.

Not done: the issue asks for before and after looks at 360px and 1280px, and this pull has none because I couldn't capture screenshots here. Compare / as an admin on production and on this pull's preview at both widths. The card should look the same: still centred at 1040px, with the same 8px gap between each row's controls.

🤖 Generated with Claude Code

Closes #5065

commented

The front page's admin controls no longer use their own .front-admin and .front-pick classes. They now draw from the shared §5 pieces, and both rules are gone from src/web/style/content.ts and from the docs/DESIGN.md §5d list.

What moved where:

  • The controls in each row (src/web/studio/home.ts, frontControls): they now sit in §5's .row-trail, which gives the same 8px gap .front-pick gave. The action forms lose class="inline", so the .front-pick form.inline { margin-left: 0 } override isn't needed.
  • The 1040px centred width (src/web/studio/home.ts, studioDoor, and content.ts): it moves from the .front-admin wrapper onto the card's existing [data-front-settings] rule, next to its other rules. The wrapper keeps only mt.

The earlier check failure: pull #5086 failed on test/spawn-child-runs-apps.test.ts. That suite starts a hosted child forge process and never renders the front page or loads the stylesheet, so it doesn't depend on anything this pull changes. It passes here, 6/6.

Checks run: this branch is main merged in again, with the same change. bun x tsc --noEmit and bun scripts/design-lint.ts are clean. The front, studio-door, home and design suites pass: 72 pass, 6 skipped by the sandbox, 0 fail.

Not done: the issue asks for before and after looks at 360px and 1280px, and this pull has none because I couldn't capture screenshots here. Compare / as an admin on production and on this pull's preview at both widths. The card should look the same: still centred at 1040px, with the same 8px gap between each row's controls.

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("apps: production, previews, data, gates > require_checks holds the merge until the head's deploy is green") and the decider saw no point in another try

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs