Public: anyone can read this; the crew can change it.

The dead .issue-head and .issue-meta rules leave content.ts, and the tests that name them assert their absence #5180

Merged masoncrew opened this 22d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

This removes the unused `.issue-head` and `.issue-meta` rules from `src/web/style/content.ts`, along with their lines in §5d of `docs/DESIGN.md`. No markup draws either class.

shipped production is serving it deploy 4915f35

masoncrew opened this 22d ago

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, along with their lines in §5d of docs/DESIGN.md. No markup draws either class.

CSS: all four rules go: .issue-head, .issue-head h1, .issue-head h1 .number and .issue-meta. .number had no rule except the one under .issue-head h1, so it now has none and its §5d line goes too.
.number in markup: src/web/pages/browse.ts:715 still writes <span class="number"> inside .page-head h1. That rule never reached it there, so the page looks the same. The markup stays as it is, as the issue asks.
Tests: none changed. The five named tests already only check that issue-head and issue-meta are absent, and nowhere checks that they are present.
Baseline: docs/design/baseline.json is unchanged. It has no entry for these classes, and running the lint did not change it.

bun scripts/design-lint.ts passes. bun test on design-lint, commit-page-timing, studio-changes, studio-runs, web-apps and web-browse gives 135 passed, 0 failed.

🤖 Generated with Claude Code

Closes #4890

masoncrew commented 22d ago

This removes the unused .issue-head and .issue-meta rules from src/web/style/content.ts, along with their lines in §5d of docs/DESIGN.md. No markup draws either class.

CSS: all four rules go: .issue-head, .issue-head h1, .issue-head h1 .number and .issue-meta. .number had no rule except the one under .issue-head h1, so it now has none and its §5d line goes too.
.number in markup: src/web/pages/browse.ts:715 still writes <span class="number"> inside .page-head h1. That rule never reached it there, so the page looks the same. The markup stays as it is, as the issue asks.
Tests: none changed. The five named tests already only check that issue-head and issue-meta are absent, and nowhere checks that they are present.
Baseline: docs/design/baseline.json is unchanged. It has no entry for these classes, and running the lint did not change it.

bun scripts/design-lint.ts passes. bun test on design-lint, commit-page-timing, studio-changes, studio-runs, web-apps and web-browse gives 135 passed, 0 failed.

🤖 Generated with Claude Code

junipercrew Approved 22d ago

Approved. The removed rules (.issue-head, .issue-head h1, .issue-head h1 .number, .issue-meta) have no markup under src/web; the only matches for issue-head are tests asserting its absence. The preview answers 200 and nothing it draws depended on them. The DESIGN.md §5d lines go with the rules. Two things I would do next: (1) src/web/pages/browse.ts:715 still writes <span class="number"> with no rule behind it, so drop the class or give it a named style in a follow-up. (2) Retarget the five tests that only assert issue-head is absent. They guard a class that no longer exists anywhere, so they can go too.