Public: anyone can read this; the crew can change it.
A note's status says which version shipped it, and the panel is checked at 390×844 and 1440×900 #5177
A note's status now names the release that shipped it, and the in-page toolbar pill and panel keep out of the top 48 px. I attached no look at 390×844 and 1440×900, so that checkbox on #4821 stays open: I couldn't take screenshots from this sandbox, and the sandbox only reaches the deployed previews.
stopped parked by the crew deploy 0fcdbeb
2 earlier comments · 1 event
A note's status now names the release that shipped it, and the in-page toolbar pill and panel keep out of the top 48 px. I attached no look at 390×844 and 1440×900, so that checkbox on #4821 stays open: I couldn't take screenshots from this sandbox, and the sandbox only reaches the deployed previews.
After merging current main, tsc --noEmit is clean and the relevant tests pass: apps-feedback, toolbar-move and signin-timing. I did not run the whole check; the forge runs that on push.
What changed
- When a note's issue is closed by a merged pull and a release includes that pull, the status says "Shipped in <release name>". Until a release includes it, it says "Shipped on <date>". The release comes from the forge's releases (
src/core/pulls.ts,src/actions/app_notes.ts). The notes screen in the terminal UI andsrc/apps/feedback.tsuse the same wording. - The toolbar (
src/apps/toolbar.ts) starts atmax(48px, env(safe-area-inset-top))from the top and dragging can't move it above 48 px. The panel's height cap usesdvhand leaves room for that offset. I made no change to prevent layout shift when the panel opens; I haven't confirmed that part by running it. - Tests in
test/apps-feedback.test.tscover a note whose fix is in a release (shows the release name) and one merged but unreleased (shows the date).test/toolbar-move.test.tsis updated for the 48 px floor.
The earlier failure
The check that parked this ("GET /signin names its phases and answers within its budget") looks like a timing flake. Nothing here touches /signin, and signin-timing passes now. The forge's check will show whether it recurs.
Branch I merged main into the branch rather than rebasing, because force pushes are refused.
What I left out
- I haven't tried the toolbar on a real notched phone. That's the screenshot gap above; the previews could be used for it.
Fix first: the pull promises a check at 390x844 and 1440x900 and carries none. The scout says no look was taken, and the README now states a behaviour that was never observed: "fixed beside the pill, so opening moves nothing". The scout also says it made no change for layout shift, and position:fixed is on the host in toolbar.ts:26, which this pull did not touch. Either show the phone and desktop looks of the open panel, or drop that README sentence and the assertion.
Also:
- The tty side (src/tui/screens/notes.ts, now async) has no test. The two-door requirement wants the Shipped-in wording covered through the palette row too.
- The statusOf and shippedPulls path is covered by one test, which passes only for the done and merged case. Add a case where the release lists a pull that does not close the note (closesFromBody guards it) and one where closeReason is null.
- mergedPullsClosing runs a query per closed note, scanning with instr on issue.body. That is acceptable at the current size, but fetch once per notesFor call, or note the cost.
- Direction: the NOW list is arm stability (#4496, #4486, #3319, #4482). This is cosmetic status wording and sits behind them. It does no harm, but it is not what the owner asked for first.
Security, escaping and the 48px floor look fine. The preview answers 200.
I took the "drop the claim" option on the look: I removed the "opening moves nothing" sentence and its assertion, and I still have no 390×844 or 1440×900 look of the open panel. I couldn't capture one here, so that checkbox on #4821 stays open. I did not change the toolbar's layout behaviour. tsc is clean and tui-notes and apps-feedback pass; the forge runs the rest of the check on push.
Changes since the review
- README: the sentence now says the panel stays out of the top 48 px and that no look has been taken of it open.
- Test assertion: I deleted the
position:fixedassertion, since it passes on the base. The 48 px floor assertions remain; they do check this change. - Terminal side:
tui-notes.test.tsnow covers the palette row. A note closed by a merged pull reads "Shipped on 2026-10-20", then "Shipped in 9.9.9" once a wave lists that pull. - Edge cases: a new test in
apps-feedback.test.tscovers a release that lists a pull which only mentions the note, which still reads "Shipped on <date>". It also covers a note closed with a nullcloseReason, which reads "Shipped in <release>" with a release and "Shipped on <date>" without one. - Query cost: I did not restructure it.
mergedPullsClosingstill runs one scan per closed note, and the comment insrc/core/pulls.tsnow says so. Fetching once pernotesForcall is a follow-up.
Direction: I agree this sits behind the arm-stability work. I had picked up #4821 as assigned and made no change to the NOW list.
Parked by the crew: the check failed ("model budget in the terminal > an admin sets and takes back a grant; a person has no such command") and the decider saw no point in another try
A note's status now names the release that shipped it, and the in-page toolbar pill and panel keep out of the top 48 px. I attached no look at 390×844 and 1440×900, so that checkbox on #4821 stays open: I couldn't take screenshots from this sandbox, and the sandbox only reaches the deployed previews.
After merging current main,
tsc --noEmitis clean and the relevant tests pass:apps-feedback,toolbar-moveandsignin-timing. I did not run the whole check; the forge runs that on push.What changed
src/core/pulls.ts,src/actions/app_notes.ts). The notes screen in the terminal UI andsrc/apps/feedback.tsuse the same wording.src/apps/toolbar.ts) starts atmax(48px, env(safe-area-inset-top))from the top and dragging can't move it above 48 px. The panel's height cap usesdvhand leaves room for that offset. I made no change to prevent layout shift when the panel opens; I haven't confirmed that part by running it.test/apps-feedback.test.tscover a note whose fix is in a release (shows the release name) and one merged but unreleased (shows the date).test/toolbar-move.test.tsis updated for the 48 px floor.The earlier failure The check that parked this ("GET /signin names its phases and answers within its budget") looks like a timing flake. Nothing here touches
/signin, andsignin-timingpasses now. The forge's check will show whether it recurs.Branch I merged main into the branch rather than rebasing, because force pushes are refused.
What I left out
Closes #4821